Repository navigation
Fix Syslog result contrast across theme row states - #429
Open
somethingwithproof wants to merge 4 commits into
Open
somethingwithproof wants to merge 4 commits into
somethingwithproof wants to merge 4 commits into
Conversation
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
|
somethingwithproof
marked this pull request as ready for review
October 26, 2026 22:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #428.
Syslog rows paint severity surfaces independently of the host theme. Use the sampled foreground and an opaque card surface for rows and severity controls, and override forced host selection colors within the Syslog results scope. An outline keeps selected rows visible.
Adds browser checks for light, dark, and muted dark palettes across resting, hovered, selected, and selected-hovered states, including host !important rules. The existing Playwright dependency runs these checks in CI and uploads screenshots and Chromium CSS coverage. README and documentation include populated synthetic interface-alert screenshots.
Validation: browser regression checks pass; all changed executable CSS lines are covered. The companion Cacti compatibility matrix exercises the actual Syslog CSS and theme-token script across twelve theme variants. These are browser component fixtures, not backend/poller E2E tests.