Repository navigation
Fix alert rule tester misses after messages move into history - #426
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
xmacan
previously approved these changes
Oct 26, 2026
|
xmacan
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An alert condition such as message begins with
Disconnectcan report no matches in the tester after a matchingDisconnected ...message has moved from the incoming buffer to stored history.When a condition-builder alert preview has no incoming matches, also test the newest 10,000 stored messages. Reuse the existing normalized filter compiler for host/program conditions, restore host/program names in samples, and label the historical scope in the preview dialog. Keep the existing ten-row response cap.
Alarm processing, Alarm Manager integration, SQL previews and removal previews are unchanged. Historical testing is read-only and never replays messages as alarms.
Related Issue
None linked.
Motivation and Context
The incoming table is temporary, so incoming-only previews can return zero for messages users can still see in stored history. A bounded historical fallback makes those condition-builder tests useful without scanning all retained messages.
How Has This Been Tested?
Types of changes
Checklist