Repository navigation
Add optional per-rule Alarm Manager forwarding through native hooks - #425
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Update locales/po/cacti.pot for the new Alarm Manager strings - Use a SHA-256 based threshold rule fingerprint (same 40-char width) - Move destination visibility logic to js/alarm-destination.js and drop dynamic code execution / PATH-based PHP lookup from regression tests - Use prepared SQL in the threshold recovery regression test - Add Pest coverage for Alarm Manager forwarding and register includes/alarmmanager.php in test harness and coverage config Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cover the queued threshold recovery forward and the message-alert fallback email path so the patch-coverage gate reaches 100%. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
xmacan
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional per-rule forwarding to Alarm Manager through Cacti's native
alarmmanager_submithook. Syslog Alarming remains the default, with an off-by-default global forwarding setting.acceptedoralready_acceptedand a valid event row ID. Unavailable, rejected, failed or malformed submissions retain configured email fallback.Related Issue
None linked.
Motivation and Context
Syslog currently owns notification delivery for every rule. This adds an explicit destination choice while preserving existing rules and conservative fallback behavior.
Raise submission remains synchronous. A crash between Alarm Manager's ingestion commit and the local recovery-ownership write can leave an accepted raise without a forwarded clear; this limit is documented.
How Has This Been Tested?
Types of changes
Checklist