Repository navigation
Remote collector support - #386
Merged
Merged
Conversation
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fresh-install schema gaps, incomplete realm migration, dedicated-database incompatibility, and a parallel-transfer data-loss path must be addressed.
Review effort: Balanced
Findings: 4
Open (10)
What changed in this PR
Adds durable remote-collector Syslog replication, centralized delivery, recovery, telemetry, and granular rule permissions.
Changes:
- Adds remote replication outbox, recovery worker, central receipts, and status telemetry.
- Splits rule viewing/editing permissions and strengthens mutation authorization.
- Expands partition observability, schema migrations, localization, and tests.
| File | Description |
|---|---|
functions.php |
Implements replication, recovery, telemetry, and rule authorization. |
setup.php |
Adds schemas, settings, realms, and migrations. |
syslog_process.php |
Triggers delivery and recovery after processing. |
syslog_recovery.php |
Adds the recovery CLI worker. |
syslog.php |
Displays replication and partition status. |
syslog_alerts.php |
Enforces rule-edit permission. |
syslog_removal.php |
Enforces rule-edit permission. |
syslog_reports.php |
Enforces rule-edit permission. |
syslog_device_rules.php |
Handles failed rule queries safely. |
css/search.css |
Styles new status tables. |
locales/po/cacti.pot |
Updates translation template references. |
INFO |
Bumps version to 4.6. |
CHANGELOG.md |
Documents new functionality. |
tests/Unit/ReplicationDeliveryTest.php |
Tests replication and recovery behavior. |
tests/Unit/StatusTelemetryTest.php |
Tests maintenance telemetry history. |
tests/Unit/MessageRuleLinksTest.php |
Updates permission-link coverage. |
tests/Unit/DeviceRulePolicyTest.php |
Tests device-rule replication setup. |
tests/Security/PartitionTableLockingTest.php |
Updates prepared-query expectations. |
tests/Security/LogicalMessageSearchTest.php |
Verifies stable union projections. |
tests/regression/rule_realm_upgrade_test.php |
Exercises realm migration behavior. |
tests/regression/partition_observability_test.php |
Tests partition health summaries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Resolved the conflicts in merge commits |
…deling after remote collector established design
Add visbility to recovery queue
While the main collector is offline, remote collectors retain processed records locally for normal viewing. After confirmed delivery to the main collector, those temporary local syslog records are removed using tracked source identities. If the admin enables the new option, remote records remain stored and recovery does not remove them. Alerts, removal rules, and replication remain in the existing processing flow.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated the Syslog replication outbox feature to ensure processed events are delivered idempotently and retained through outages. Other features include Device Alert Rules and enhancements to the Syslog Status tab. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: bmfmancini <13388748+bmfmancini@users.noreply.github.com>
bmfmancini
force-pushed
the
remote_collector_support
branch
from
October 6, 2026 19:03
23adb9e to
9eef41f
Compare
Co-authored-by: bmfmancini <13388748+bmfmancini@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TheWitness
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for remote collectors running syslog to process syslog alerts and send the messages back to the main syslog server for centralized viewing
if main syslog is offline remotes will continue to process , alarm and hold syslog events until main is back online
This follows the same model as the cacti remote collectors