Repository navigation
Use a CSS class for the status legend footer instead of inline styles - #130
Merged
Merged
Conversation
Wrap the servcheck legend render in the same fixed-position footer container MacTrack uses, so the legend stays pinned to the bottom of the viewport.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 7, 2026 20:07
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fixed legend needs reserved layout space to avoid obscuring bottom controls when its status chips wrap.
1 open finding
What changed in this PR
Pins the Service Check status legend to the viewport bottom to match MacTrack’s footer behavior.
Changes:
- Adds a full-width, fixed-position wrapper around the existing legend without changing its markup or styles.
| File | Description |
|---|---|
| servcheck_test.php | Wraps the test-list legend in a fixed footer container. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cigamit
previously approved these changes
Oct 7, 2026
Replace the inline fixed-position wrapper around the status legend with a plugin-specific *LegendFooter class defined in the plugin's stylesheet. The class lays the legend out as a centered footer in normal document flow, so it no longer sits outside flow and overlay the final rows, pagination, or action controls at the bottom of the page.
TheWitness
changed the title
servcheck_test.php is a web page controller that chdir()s and includes auth.php at the top level, so it cannot be loaded into the isolated unit process and is absent from Clover. The legend-footer edit tripped the patch-coverage gate; add it to the unmeasured allowlist.
bmfmancini
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally the status legend was wrapped in an inline-styled, fixed-position container copied from MacTrack:
Per review, the inline style is replaced with a dedicated
.servcheck_legend_footerCSS class, and it now lays the legend out as a centered footer in normal document flow rather thanposition: fixed. Staying in flow means it reserves its own space and no longer overlays the bottom pagination or bulk-action controls — resolving the reviewer's overlay finding. MacTrack and the other legend plugins (Thold/Monitor/Syslog) are being updated the same way.How
.servcheck_legend_footertocss/common.css(always loaded, alongside the existing.servcheck_legendgrid).servcheck_test.phpfor<div class="center servcheck_legend_footer">.No change to the legend chip markup/styles themselves.
Types of changes
Checklist
php -lclean on the changed files.