Repository navigation
cbor BUGFIX stale input log location on load failure - #2596
Open
affan-arch wants to merge 1 commit into
Open
affan-arch wants to merge 1 commit into
affan-arch wants to merge 1 commit into
Conversation
lycbor_ctx_new() freed the context directly when cbor_load() failed, skipping ly_log_location_revert(), so the freed ly_in stayed on the log location stack and the next logged error read its line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lycbor_ctx_new()frees the context with a barefree()whencbor_load()fails, soly_log_location_revert()never runs and thely_inthatlyd_parse_data_mem_len()frees next stays on the log location stack, which means any malformed CBOR input (a lone0xa1is enough) leaves the next logged error in that thread reading->linefrom freed memory (ASan: heap-use-after-free inly_vlog_build_path_line()); releasing it throughlycbor_ctx_free()likelyjson_ctx_new()/lyxml_ctx_new()do fixes it, andtest_invalid_inputcovers it.