Repository navigation
session server tls BUGFIX map CN by attribute OID - #649
Merged
Merged
Conversation
The common-name cert-to-name mapping searched the subject string for "CN=", so an earlier attribute such as OU=CN=root could set the username. Get the commonName by its OID instead, and skip SAN values containing a NUL character, which would otherwise get truncated.
michalvasko
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commonName CTN mapping searched the certificate subject string for the first "CN=", so a value of an earlier attribute (e.g. OU=CN=root) could determine the username. The CN is now taken by its attribute OID, using the API of both TLS backends.
Also SAN values containing a NUL character are skipped instead of being truncated.