Enable multi-threading tests (MPI+OpenMP) under CI #292

Activity

1. iomaganaris commented on Apr 21, 2020

   

   iomaganaris

   on Apr 21, 2020

   Contributor

   More actions

   In the CI we build CoreNeuron SoA with OpenMP enabled

   CoreNeuron/tests/jenkins/install_coreneuron.sh

   Line 57 in 76026e0

   ENABLE_OPENMP=ON

   and we run the SoA tests with

   CoreNeuron/tests/jenkins/run_corenrn.sh

   Line 17 in 76026e0

   export OMP_NUM_THREADS=2

   . I see though that for some reason when CoreNeuron runs it prints num_omp_thread=1 even if the OMP_NUM_THREADS is set to 2. Maybe that's because we don't run it with --threading? I need to investigate
2. iomaganaris

   self-assigned this

   on Apr 21, 2020
3. pramodk commented on Apr 21, 2020

   

   pramodk

   on Apr 21, 2020

   Last edited by pramodk

   CollaboratorAuthor

   More actions

   @iomaganaris : IMO we need a test with more concurrency (more than ring). e.g. If we are using 36 cores on Jenkis CI, using 6 MPI ranks each with 6 threads. This can help to detect race condition bit. We can discuss this what should/can do.

   👍React with 👍1Reacted by Omar Awile
4. pramodk

   added this to the NEURON release 8.0 milestone on Jul 24, 2020
5. olupton commented on Aug 25, 2022

   

   olupton

   on Aug 25, 2022

   Contributor

   More actions

   We have CI builds that enable OpenMP (host) threading:

   CoreNeuron/.gitlab-ci.yml

   Line 89 in d6507e2

   SPACK_PACKAGE_SPEC: +gpu+openmp+tests~legacy-unit build_type=RelWithDebInfo

   and tests that use multiple threads https://github.com/neuronsimulator/nrn/blob/1b76917231a00281e17bac760d013f9a5c13cd95/test/external/ringtest/CMakeLists.txt#L90-L100, but I'm not sure if this is enough.