Repository navigation
wallet: Restore history from recorded date - #191
BenWestgate wants to merge 1 commit into
Conversation
Ask for the seed's approximate first-use date on restore and reject scans a pruned or validating AssumeUTXO node cannot complete before creating or importing a wallet. Validate retained-block timestamps before date formatting and describe the actual dated scan on the finished page. Have Core persist load_on_startup at creation. Return all creation warnings for display to the operator instead of inventing a separate loading or quarantine policy. Preserve structural RPC response checks and add regressions for invalid metadata and visible warnings. Validation: Core 32 regtest with physically pruned genesis recovers a confirmed synthetic payment from the recorded date, refuses timestamp zero before mutation, and reloads restored wallets from settings.json after restart. GUI and Core boundary tests pass under Xvfb; Ruff and mypy pass. Refs BenWestgate/Bails#314
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted review at maintainer request. Concept ACK b045908 (static). The dated/pruned rescan gate and Core-managed wallet autoload have focused tests; this unchanged commit was previously reviewed in #139. The time preflight alone cannot guarantee a complete scan; stacked #113 handles late Rescan failed. Current-head CI is queued, and a real pruned-Core/Tails restore remains mandatory.
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Why
Genesis rescans on a pruned node can miss wallet history; newly created wallets must also reload on Core restart.
Change
Extracts unchanged commit
b045908from #113, previously reviewed as #139: asks for a recorded date, preflights pruning, and requestsload_on_startup=truefor new wallets, with CLI/GUI tests.Review
Stacked on the blank-record PR. #113 carries the separate safeguard for an actual rescan failure. Block times can be non-monotonic, so preflight cannot guarantee the import will rescan successfully. Supported-Tails/pruned-Core restore remains a manual release gate. AI-assisted description; responsible-human review required.