Repository navigation
Pick up the parser's Unicode line separators as whitespace - #304
Merged
Merged
Conversation
U+2028, U+2029 and U+0085 now lex as whitespace that also ends a // comment, without advancing the line counter, so a file holding one -- Qt's editor types U+2028 for Shift+Enter -- parses rather than failing with "unexpected character". BelfrySCAD #949. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs BelfrySCAD/BelfrySCAD#949
Bumps
external/openscad_cpp_parserto BelfrySCAD/openscad_cpp_parser#16. With it, U+2028, U+2029 and U+0085 lex as whitespace instead of failing with "unexpected character". A//comment also ends at one of them. They don't advance the line counter, so line numbers keep matching the editor's, and byte offsets are unchanged.All 2195 tests pass locally (parser and evaluator).
🤖 Generated with Claude Code