Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PreconditionNodekept its internal running-child flag after the tree was halted. The next activation then skipped theifexpression and ticked the child even when the condition had become false.This change resets that flag in
halt()and keeps it set only while the child returnsRUNNING. A skipped child now also ends the current activation, so the condition is checked again on the next tick.Two regression tests cover reactivation after an external halt and after a child returns
SKIPPED.Testing
PreconditionsDecorator.*andPreconditions.*: 15 passedctest --test-dir build-nonros --output-on-failure --timeout 300: 601 tests, 0 failed, 2 skipped because the required locale was unavailablegit diff --check: passed; changed lines were checked against the 90-column, two-space style.pre-commit: not run (not installed in this environment)../run_clang_tidy.sh: not run (clangd-21/clang-tidy-21are not installed in this environment).