Repository navigation
Revise GUI inputs and result controls from #299 review - #300
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the GUI revision request on #299. This follow-up depends on #299 and targets its branch,
feat/297-gui-sessions.The input panels now follow Sequences → Seed → Output → Model & Energy → Query → Target → CLI-only. Controls use the requested row order and aligned inputs; SHAPE sits beside each strand's accessibility inputs, shared accessibility flags stay synchronized, and helix controls sit under Model & Energy. The three-way seed selector and accessibility modes disable irrelevant fields and omit their stale values from computations and saved parameters.
Validation:
npm test --prefix gui: 20 passed.scripts/wasm/test-browser.pyin Chromium and Firefox at a nested URL: passed. Includes mode availability, stale disabled values, explicit-seed JSON restoration, synchronized controls, grouped CSV actions, header selection, existing session/ZIP behavior and cancellation. Desktop/mobile screenshots inspected; all panels fit at 390 px without document overflow.node scripts/wasm/smoke-protocol.mjs <staged-engine>: native-reference checks and byte-identical JSON archive replay passed.make tests -j2: all nine API/CLI groups passed. Existing CLI fixtures were linked into the out-of-tree build'stests/datadirectory.git diff --check: passed.The C++ engine and worker protocol are unchanged. Browser checks reuse the parent's compiled Emscripten 4.0.23 / ViennaRNA 2.7.2 assets with their original provenance. Sessions remain page-local; the new sequence cap applies to the largest selected pair rather than total batch work.