Repository navigation
Align probability API tests with debug-only precondition checks - #279
Open
Alexander-Mitrofanov wants to merge 3 commits into
Open
Alexander-Mitrofanov wants to merge 3 commits into
Alexander-Mitrofanov wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release API tests on the current probability branch still invoke invalid regions, conflicting seed lengths and a missing annotation mask even though commit
e3479d6moved their precondition checks behindINTARNA_IN_DEBUG_MODE. The missing mask can be dereferenced in a release test run, producing a segmentation fault rather than a test result.Guard those invalid-input cases with the same build condition as the implementation. Restore the previously commented unsupported-handler test inside the debug guard. Keep ordinary lifecycle, arithmetic, failure-state, output and valid prediction assertions enabled in both configurations. This changes four test files and ChangeLog; production predictor behavior is unchanged.
Why this was not committed before: this is a new compatibility fix found while validating the recovered October 12 memory port against the probability branch's October 13–14 changes. It was not an old uncommitted implementation. Earlier validation predated the debug-only checks; the remaining invalid-input tests had not all been aligned with them. It is separated from the recovered optimization so Martin can review the test contract independently.
The recovered memory port is stacked on this branch. Validation of the assembled series: GCC 14.4 release
make tests -j2passes all seven suites, including 101,251 API assertions in 98 cases. Debugmake tests -j2also passes all seven suites, including 101,267 API assertions in 98 cases. The mixed explicit-seed test now verifies its conservative capability contract without passing an unsupported handler to the domain constructor. The old release failure log identifies the null-mask crash and invalid-input exception expectations that this change addresses. Staged whitespace checks pass.Base:
docs/257-base-pair-probability-plan/ PR #258.