Skip to content

Sync eng/common directory with azure-sdk-tools for PR 17410 - #50996

Merged
jenny (JennyPng) merged 1 commit into
mainfrom
sync-eng-common-jennypeng/sbom-generation-timeout-17410
Oct 27, 2026
Merged

jenny (JennyPng) merged 1 commit into
mainfrom
sync-eng-common-jennypeng/sbom-generation-timeout-17410

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#17410 See eng/common workflow

Preserve the 30-minute default and pass caller overrides to the 1ES artifact task.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: ef492680-d50c-4348-967b-88a98f5c04c1
@azure-sdk-automation
azure-sdk-automation Bot requested review from a team as code owners October 27, 2026 17:37
@azure-sdk-automation
azure-sdk-automation Bot requested review from jenny (JennyPng) and a balanced review from Copilot October 27, 2026 17:37
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 27, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
35 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow template change preserves existing callers and publication conditions, with no identified blocking issues.

No open issues 🎉

What changed in this PR

Syncs the shared artifact-publishing template with azure-sdk-tools PR #17410, making the SBOM generation timeout configurable.

Changes:

  • Adds and documents SbomGenerationTimeoutInMinutes with a 30-minute default.
  • Passes the timeout to the publishing task without changing SBOM enablement conditions.
File Description
eng/​common/​pipelines/​templates/​steps/​publish-1es-artifact.yml Exposes and forwards the SBOM generation timeout.

Review effort: Balanced

@JennyPng
jenny (JennyPng) merged commit 8ded73e into main Oct 27, 2026
34 checks passed
@JennyPng
jenny (JennyPng) deleted the sync-eng-common-jennypeng/sbom-generation-timeout-17410 branch October 27, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants