Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
The B-spline curvature formula was introduced in #720. Current B-spline and spline-curvature searches found no existing repair; the older cubic-spline issue #64 concerns a separate implementation.
What does this implement/fix?
The shared B-spline evaluator raises squared tangent length to
2/3instead of3/2. Returned curvature depends on parameter speed and has incorrect physical units. For the exact parabolax(u)=u, y(u)=u², curvature atu=1is currently0.683990instead of the analytic0.178885. Doubling a public interpolation path multiplies curvature by1.587401; it should halve it.Evaluate signed planar curvature using
hypotfor tangent length, a normalized tangent, and successive divisions by its length. This is algebraically(x′y″−y′x″)/(x′²+y′²)^(3/2)while avoiding cubed-length underflow for a finite straight path scaled by1e-110. Public positions and headings are preserved. Both public docstrings now describe inverse-position units, and the existing official B-spline page explains the equation, sign, scale invariance and undefined zero-tangent case.Regressions use closed-form positive and negative parabolas at three parameter speeds, interpolation and smoothing at degrees 2–5 under two spatial scales, and straight-path controls. Additional straight and signed-parabola cases cover finite coordinate scales
1e-110and1e110.Additional information
cdd0cc888802b584c2d654ca85e3c5460973487d.-Werror.bash runtests.sh: 188 passed, including the actual changed-file Ruff and all nine configured mypy scopes. No skip or deselection was added.git diff --checkpass.make htmlpasses on Python 3.13.16 with the exact project and documentation requirements. The exact-base documentation build also passed. Generated equation markup, both function source links, local images and parent navigation were checked.ci/circleci: build_doc/ artifact stage runs and its changed page can be inspected. Local HTML rendering was unavailable, and no browser-security, file-protocol or hosting workaround was used. A successful build is not claimed as rendered-page QA.AI assistance: prepared with OpenAI Codex (
gpt-6.1-sol). The native validation above was executed in the current environment.CheckList