Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The Clothoid planner passes
fsolve's one-element input array directly into scalar quadrature and trigonometry, then retains the solver's array result. With the project's current NumPy pins, valid paths returnNoneafter a scalar-conversion error. The existing animation-free smoke test still passes because it does not inspect the generated paths.Extract the scalar fitting parameter at the solver boundary. Read the solver's diagnostics and require a finite root and residual. A stalled result is accepted only when the dimensionless residual is within double-precision roundoff; this preserves analytic circular paths whose exact root is zero under the existing warnings-as-errors test policy. Larger failed-fit residuals remain errors.
The initial guess, fitting equations, public path inputs, units and point-list contract are unchanged. The existing official RST equations and explanation remain correct, so this code-only correction adds no documentation, figure or animation change.
Validation
cdd0cc888802b584c2d654ca85e3c5460973487d.-Werror.bash runtests.sh: 182 passed on Linux/Python 3.14.8 with the exact requirements, including the configured diff-Ruff and mypy checks. No skips or deselections were added.AI assistance: prepared with OpenAI Codex (
gpt-6.1-sol). The native validation above was executed.