Repository navigation
Wrap goal-heading comparisons in Dubins and closed-loop RRT - #1457
Open
huxiaoyi-ovo wants to merge 1 commit into
Open
huxiaoyi-ovo wants to merge 1 commit into
huxiaoyi-ovo wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goal-heading comparisons in Dubins and closed-loop RRT planners currently use raw yaw subtraction. Because heading is circular, equivalent poses on opposite sides of ±π (or separated by a full turn) can be rejected.
Use the existing
utils.angle.angle_modto compare the shortest signed heading difference at four sites:RRTDubins.search_best_goal_nodeRRTStarDubins.search_best_goal_nodeClosedLoopRRTStar.get_goal_indexesClosedLoopRRTStar.check_tracking_path_is_feasibleThis complements #1422, which handles the corresponding Reeds-Shepp goal-node check. There is no file overlap with #1422.
Regression coverage
Add
tests/test_rrt_goal_heading.pywith 22 parameterized cases covering both directions across ±π, ±2π heading offsets, non-equivalent headings, and the closed-loop tracked terminal-heading check. The closed-loop test isolates the heading predicate using a mocked tracking result, keeping the original path feasibility checks otherwise intact.Validation
Validated commit
f03f0c4din fork staging PR #1:bash runtests.sh— 178 passedbash runtests.sh— 178 passedbash runtests.sh— 178 passedThe patch contains only the four heading comparisons, three imports, and the targeted regression test.