Skip to content

fix: update MiniMax TTS default model - #9198

Closed
octo-patch wants to merge 2 commits into
AstrBotDevs:masterfrom
octo-patch:octo/20260709-refresh-minimax-tts-default-to-speech-28-hd-recvoRQLxBrQF9
Closed

octo-patch wants to merge 2 commits into
AstrBotDevs:masterfrom
octo-patch:octo/20260709-refresh-minimax-tts-default-to-speech-28-hd-recvoRQLxBrQF9

Conversation

@octo-patch

@octo-patch octo-patch commented Jul 9, 2026 •

Copy link
Copy Markdown
Contributor

Reason: MiniMax TTS is integrated but still defaults to speech-02-turbo instead of the target speech-2.8-hd model.

Summary

  • Update the built-in MiniMax TTS provider template to default to speech-2.8-hd.

Validation

  • uv run --group dev pytest tests/unit/test_config.py (41 passed)
  • uv run --group dev ruff format --check astrbot/core/config/default.py tests/unit/test_config.py
  • uv run --group dev ruff check astrbot/core/config/default.py tests/unit/test_config.py
  • git diff --check

Use the current MiniMax HD speech model for new TTS provider configurations and lock the default with a focused regression test.
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default model for MiniMax TTS from 'speech-02-turbo' to 'speech-2.8-hd' in the configuration, and adds a corresponding unit test to verify this default setting. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The test hardcodes the provider display name key "MiniMax TTS(API)", which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust.
  • Accessing deeply nested CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"] directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The test hardcodes the provider display name key `"MiniMax TTS(API)"`, which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust.
- Accessing deeply nested `CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"]` directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread tests/unit/test_config.py Outdated
}


def test_minimax_tts_default_model_is_speech_28_hd():

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add a new unit test for this change.

@octo-patch octo-patch changed the title Update MiniMax TTS default model fix: update MiniMax TTS default model Jul 13, 2026
@octo-patch

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I removed the additional unit test as requested and pushed commit 465e6e49. The final change is limited to the MiniMax TTS default configuration; I ran uv run --group dev pytest tests/unit/test_config.py, Ruff format and lint checks on the affected files, and git diff --check.

@anka-afk

Copy link
Copy Markdown
Member

Thank you for your contribution! We’re closing this PR as part of a cleanup of pull requests that have had no updates for over 90 days. The project has evolved since this PR was opened, and the changes may need to be revisited.

If this change is still needed and you’d like to continue working on it, please feel free to reopen the PR and update it against the latest master. We’d be happy to take another look.

@anka-afk anka-afk closed this Oct 12, 2026
@Soulter Soulter moved this to Closed unmerged in AstrBot Roadmap Nov 2, 2026
@github-project-automation github-project-automation Bot moved this from Closed unmerged to Done in AstrBot Roadmap Nov 2, 2026
@Soulter Soulter moved this from Done to Closed unmerged in AstrBot Roadmap Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Closed unmerged

Development

Successfully merging this pull request may close these issues.

3 participants