Repository navigation
fix: update MiniMax TTS default model - #9198
octo-patch wants to merge 2 commits into
Conversation
Use the current MiniMax HD speech model for new TTS provider configurations and lock the default with a focused regression test.
There was a problem hiding this comment.
Code Review
This pull request updates the default model for MiniMax TTS from 'speech-02-turbo' to 'speech-2.8-hd' in the configuration, and adds a corresponding unit test to verify this default setting. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The test hardcodes the provider display name key
"MiniMax TTS(API)", which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust. - Accessing deeply nested
CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"]directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The test hardcodes the provider display name key `"MiniMax TTS(API)"`, which could be brittle if the label changes; consider keying the lookup by a more stable identifier (e.g., provider id or enum) to make the test more robust.
- Accessing deeply nested `CONFIG_METADATA_2["provider_group"]["metadata"]["provider"]["config_template"]` directly in the test couples it tightly to the config structure; consider introducing a small helper or fixture that encapsulates this lookup so future structural changes only need to be updated in a single place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| } | ||
|
|
||
|
|
||
| def test_minimax_tts_default_model_is_speech_28_hd(): |
There was a problem hiding this comment.
no need to add a new unit test for this change.
|
Thanks for the review. I removed the additional unit test as requested and pushed commit |
|
Thank you for your contribution! We’re closing this PR as part of a cleanup of pull requests that have had no updates for over 90 days. The project has evolved since this PR was opened, and the changes may need to be revisited. If this change is still needed and you’d like to continue working on it, please feel free to reopen the PR and update it against the latest |
Reason: MiniMax TTS is integrated but still defaults to speech-02-turbo instead of the target speech-2.8-hd model.
Summary
speech-2.8-hd.Validation
uv run --group dev pytest tests/unit/test_config.py(41 passed)uv run --group dev ruff format --check astrbot/core/config/default.py tests/unit/test_config.pyuv run --group dev ruff check astrbot/core/config/default.py tests/unit/test_config.pygit diff --check