Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the selection is applied incorrectly, a plugin the user meant to skip could still be updated, changing its installed code and potentially its stored state. Reverting this UI change would not restore that plugin version, though the affected updates are bounded and can generally be repaired by updating or reinstalling the plugin.
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10559.
The installed-plugin update action currently updates every plugin with a detected new version. Users cannot skip a plugin while updating others. This change lists available updates with checkboxes, selects all by default, and submits only the checked plugins. For example, with three updates available, unchecking one sends only the other two plugin names to the existing batch update API.
Modifications / 改动点
Add a scrollable list of localized plugin names and checkboxes to the existing confirmation dialog. Reset to all selected each time the dialog opens, show the selected count, and disable confirmation when no plugins are selected.
Filter batch update targets by the selection and current update availability before calling
pluginApi.updateMany. The affected flow is the installed-plugin confirmation dialog, its composable, and the existing batch update API.Rename Update All → Batch Update Plugins and update the confirmation and success messages in all four locales.
Update the Chinese and English plugin guides and WebUI entry mappings, and record the rename in the unreleased changelog. These documentation changes accompany the same feature to satisfy the repository's WebUI documentation checklist.
This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Verification Steps
{"names":["preview_weather"],"proxy":""}and that the success message refers to selected plugins.Check Results
cd dashboard && pnpm exec vue-tsc --noEmit— passed.cd dashboard && pnpm build— passed.cd dashboard && pnpm i18n:check— passed; all four locales expose 4,130 matching leaf keys.{count}placeholders — verified.ruff format .— 516 files unchanged;ruff check .— passed.cd docs && pnpm run docs:build— passed.git diff --check— passed.Browser verification used sample plugins and a mocked update endpoint; real plugin downloads/reloads and backend tests were not run. The PR changes the frontend selection and documentation without changing API schemas, backend update behavior, or dependencies.
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
📚 I checked the affected WebUI instructions and screenshots in
docs/zhanddocs/enagainst the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog./ 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新
docs/zh和docs/en的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
The feature request is tracked in #10559. Verification steps and test results are provided above; screenshots are stored as PR attachments outside Git.
Summary by Sourcery
Enable selective plugin updates from the installed-plugin batch update workflow while documenting the renamed action and revised behavior.
New Features:
Enhancements:
Documentation: