Skip to content

fix: preserve Telegram hidden links in converted messages - #10557

Merged
Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/telegram-hidden-links
Oct 15, 2026
Merged

Soulter merged 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/telegram-hidden-links

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Telegram hidden link URLs were lost during message conversion. Preserve them as label (URL) so models and plugins can read them.

Modifications / 改动点

  • Preserve links in message text, media captions, and full or partial replies.

  • Add regression coverage for UTF-16 offsets, mentions, and quote boundaries.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

Verification: send linked text or a photo caption, then reply asking for its URL. The converted text should retain the URL. Partial quotes should include only overlapping links.

Tests: 53 Telegram tests passed; Ruff formatting/lint and diff checks passed. Telegram full-reply behavior was verified manually.

Before

Before

After

After

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Preserve hidden Telegram link URLs throughout message conversion so downstream models and plugins can access them.

Bug Fixes:

  • Preserve Telegram hidden-link URLs in converted message text, media captions, full replies, and matching partial quotes.

Enhancements:

  • Handle Telegram UTF-16 entity offsets while preserving link placement alongside mentions and other message content.

Tests:

  • Add regression coverage for hidden links in text and captions, full replies, partial quote boundaries, UTF-16 offsets, and mentions.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review October 14, 2026 08:14

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Soulter
Soulter merged commit 9441402 into AstrBotDevs:master Oct 15, 2026
23 checks passed
BegoniaHe added a commit to Xero-Team/AstrBot that referenced this pull request Oct 16, 2026
@wcqqq1214
wcqqq1214 deleted the fix/telegram-hidden-links branch October 19, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants