Repository navigation
Conversation
wcqqq1214
marked this pull request as ready for review
October 9, 2026 19:59
Contributor
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the segmentation or snapshot bookkeeping is wrong, chat replies and reasoning can be persisted as incorrectly split or combined records, and reverting will not remove those already-saved histories. The damage is bounded and can be repaired or recomputed, but it is not undone automatically by a revert.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two WebChat bugs with different trigger conditions:
Normal WebChat streaming replies use a separate delivery path and do not trigger these bugs. Enabling the segmented-reply setting does not split a normal streaming reply into separate messages.
Modifications / 改动点
Preserve separate reply messages in the main chat, threads, saved history, and reconnect snapshots.
Keep text and attachments from one send together; replace all old segments on regeneration and keep queued replies in order.
Send reasoning as a thinking part attached to the first reply instead of splitting it into body text.
Add regression coverage and document the SSE message boundaries and snapshot fields.
This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Verification steps:
Automated checks passed:
cd dashboard && node --test tests/chatSegmentedReply.test.mjs: 18 tests.uv run --no-sync pytest -q tests/test_chat_route.py tests/unit/test_webchat_follow_up_status.py tests/unit/test_webchat_message_parts.py tests/test_webchat_queue_lifecycle.py: 35 tests.Before — without refreshing: Only the last segment remains visible.
Before — after refreshing: All three saved segments reappear.
After — without refreshing: All three segments remain visible as separate messages.
After — after refreshing: Message content, boundaries, and order remain unchanged.
Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
📚 I checked the affected WebUI instructions and screenshots in
docs/zhanddocs/enagainst the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog./ 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新
docs/zh和docs/en的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Preserve WebChat reply segments and reasoning types across delivery, persistence, reconnection, and regeneration.
Bug Fixes:
Enhancements:
Documentation:
Tests: