Repository navigation
tests: start the served fixture on a free port - #40
Merged
Merged
Conversation
PR #28 added the served fixture in test_server_packaging.py after #36 was written, so it still started its server on the default fixed port 2480 and errored whenever anything else held that port. It now passes config={"http_port": free_port()} like every other server test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
8 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #36. PR #28 added the
servedfixture totests/test_server_packaging.pyafter #36 was written, so that fixture still started its server on the default fixed port 2480.test_openapi_json_is_servedandtest_snappy_compressed_bodies_are_decodedtherefore errored with "Unable to listen to a HTTP port in the configured port range 2480 - 2480" whenever anything else on the machine held 2480.The fixture now passes
config={"http_port": free_port()}, the helper #36 added totests/conftest.py. It was the only server start intests/still on a fixed port.test_server.py::test_default_host_is_localhostbuilds a server without starting it, so it binds nothing and stays as is.test_server_wire_protocols.pyalready used_free_ports. isort also added the blank line between the third-party and first-party imports in that fixture.Checked with a dummy listener holding 0.0.0.0:2480, pinned
taskset -c 0-3, on the 26.11.1.dev0 cp312 wheel. Before the changetests/test_server_packaging.pygave 4 passed, 2 errors (the twoservedtests, with the message above). After it gives 6 passed. All the server test files together (test_server.py,test_server_packaging.py,test_server_patterns.py,test_server_http_endpoints.py,test_server_wire_protocols.py) give 32 passed with 2480 held. pre-commit is clean.🤖 Generated with Claude Code