Repository navigation
docs(#6): drop the monorepo wording after the move - #21
Merged
Merged
Conversation
_version.py is derived from the engine jar's version, not a Maven pom, and there is no repo-root uv project: tests run against the wheel installed with its test extra into .venv. README, tests/README, the pyproject [tool.uv] comment and build.sh's next steps say so, with commands that work on every rebuild (--reinstall-package, as a rebuild keeps the version). build.sh no longer points at a docs/development/release.md this repository does not have. tests/test_no_monorepo_wording.py keeps it so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Reopens #15 against
main. #15 was stacked on #12, but it merged into #12's branch after #12 itself had already merged, so its commit never reachedmain. This PR carries the same commit (9e9049a) unchanged, directly onmain, which already has #12.This removes the wording left over from the monorepo layout:
_version.pyis described as derived from the engine jar's version (scripts/write_version.py) instead of "the Maven pom". This coverssrc/arcadedb_embedded/__init__.pyand the docstrings intests/test_jar_provenance.pyandtests/test_wheel_platform_tag.py. Only docstrings change; no assertion does.tests/README.md, thepyproject.toml[tool.uv]comment andbuild.sh's next steps now describe what actually works:uv venvonce, then after each builduv pip install --reinstall-package arcadedb-embedded "<wheel>[test]", thenuv run pytest.build.shno longer points atdocs/development/release.md, which this repository doesn't have.Test plan
uv venv,uv pip install --reinstall-package arcadedb-embedded "$(ls dist/*.whl | head -1)[test]", thenuv run pytest tests/test_extract_version.py tests/test_jar_provenance.py. 14 passed.tests/test_no_monorepo_wording.pyscanssrc/,tests/,scripts/,pyproject.tomland both READMEs forMaven pom,from the pom,repo-rootanddocs/development/. Text inside double quotes counts as a quotation and is ignored. RED: on amainexport it finds 8 lines. GREEN: it passes here.Coverage
Invariant: no tracked text tells a reader about a pom or a repo-root uv project, and the documented test commands work on every rebuild.
git grep -nEi '\bpom\b|pom\.xml|maven pom|repo-root|repo root|bindings/python|parents\[3\]' -- . ':!docs/superpowers'finds these sites:src/arcadedb_embedded/__init__.py:10tests/test_jar_provenance.py:3,tests/test_wheel_platform_tag.py:142pyproject.toml:39-43README.mdTesting,tests/README.mdbuild.shnext stepsbuild.shrefresh blockThese stay deliberately:
README.md:144("moved here frombindings/python") and the.gitignoreheader are history.tests/test_check_test_skips.py:53is test data.tests/test_extract_version.py:3says this repo has no pom, which is true.Known gaps: None.
Adversarial pass
uv venvfails ("already exists"). Real. Fixed: the docs now sayuv venvonce, and build.sh no longer chains it.26.11.1.dev0version). Real; reproduced with--dry-run. Fixed: the commands use--reinstall-package arcadedb-embedded, and a dry run now shows the uninstall and install.docs/development/release.md. Fixed: the line is removed, and the scan test coversdocs/development/.Review cycles
This repository has no Claude review workflow, so no bot review was waited for. Final state:
no-reviewer.🤖 Generated with Claude Code