Skip to content

docs(#6): drop the monorepo wording after the move - #21

Merged
robfrank merged 1 commit into
mainfrom
fix/6-stale-pom-wording
Oct 23, 2026
Merged

robfrank merged 1 commit into
mainfrom
fix/6-stale-pom-wording

Conversation

@robfrank

Copy link
Copy Markdown
Contributor

Closes #6

Reopens #15 against main. #15 was stacked on #12, but it merged into #12's branch after #12 itself had already merged, so its commit never reached main. This PR carries the same commit (9e9049a) unchanged, directly on main, which already has #12.

This removes the wording left over from the monorepo layout:

  • _version.py is described as derived from the engine jar's version (scripts/write_version.py) instead of "the Maven pom". This covers src/arcadedb_embedded/__init__.py and the docstrings in tests/test_jar_provenance.py and tests/test_wheel_platform_tag.py. Only docstrings change; no assertion does.
  • There is no repo-root uv project. README, tests/README.md, the pyproject.toml [tool.uv] comment and build.sh's next steps now describe what actually works: uv venv once, then after each build uv pip install --reinstall-package arcadedb-embedded "<wheel>[test]", then uv run pytest.
  • build.sh no longer points at docs/development/release.md, which this repository doesn't have.

Test plan

  • I ran the documented commands in a fresh worktree: uv venv, uv pip install --reinstall-package arcadedb-embedded "$(ls dist/*.whl | head -1)[test]", then uv run pytest tests/test_extract_version.py tests/test_jar_provenance.py. 14 passed.
  • tests/test_no_monorepo_wording.py scans src/, tests/, scripts/, pyproject.toml and both READMEs for Maven pom, from the pom, repo-root and docs/development/. Text inside double quotes counts as a quotation and is ignored. RED: on a main export it finds 8 lines. GREEN: it passes here.
  • Full suite on darwin/arm64: 1062 passed.

Coverage

Invariant: no tracked text tells a reader about a pom or a repo-root uv project, and the documented test commands work on every rebuild.

git grep -nEi '\bpom\b|pom\.xml|maven pom|repo-root|repo root|bindings/python|parents\[3\]' -- . ':!docs/superpowers' finds these sites:

Site Fixed
src/arcadedb_embedded/__init__.py:10 yes
tests/test_jar_provenance.py:3, tests/test_wheel_platform_tag.py:142 yes (docstrings)
pyproject.toml:39-43 yes
README.md Testing, tests/README.md yes
build.sh next steps yes
build.sh refresh block removed in #12

These stay deliberately:

  • README.md:144 ("moved here from bindings/python") and the .gitignore header are history.
  • tests/test_check_test_skips.py:53 is test data.
  • tests/test_extract_version.py:3 says this repo has no pom, which is true.

Known gaps: None.

Adversarial pass

  1. A second uv venv fails ("already exists"). Real. Fixed: the docs now say uv venv once, and build.sh no longer chains it.
  2. Reinstalling a rebuilt wheel did nothing (same 26.11.1.dev0 version). Real; reproduced with --dry-run. Fixed: the commands use --reinstall-package arcadedb-embedded, and a dry run now shows the uninstall and install.
  3. The stale repo-root block is still in build.sh. Removed by fix(#5): drop build.sh's uv dev-environment refresh #12, which this PR is stacked on.
  4. The next steps pointed at the missing docs/development/release.md. Fixed: the line is removed, and the scan test covers docs/development/.

Review cycles

This repository has no Claude review workflow, so no bot review was waited for. Final state: no-reviewer.

🤖 Generated with Claude Code

_version.py is derived from the engine jar's version, not a Maven pom, and
there is no repo-root uv project: tests run against the wheel installed
with its test extra into .venv. README, tests/README, the pyproject
[tool.uv] comment and build.sh's next steps say so, with commands that
work on every rebuild (--reinstall-package, as a rebuild keeps the
version). build.sh no longer points at a docs/development/release.md this
repository does not have. tests/test_no_monorepo_wording.py keeps it so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robfrank
robfrank merged commit e5138fe into main Oct 23, 2026
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stale pom.xml / repo-root pyproject wording after the move

1 participant