Skip to content

Antalya 25.8 - Fix PREWHERE filter in Parquet files - #2627

Merged
mkmkme merged 6 commits into
antalya-25.8from
fix/antalya-25.8/not-found-in-block
Oct 22, 2026
Merged

mkmkme merged 6 commits into
antalya-25.8from
fix/antalya-25.8/not-found-in-block

Conversation

@mkmkme

@mkmkme mkmkme commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

This PR contains backporting 3 upstream PRs with some fixes:

  1. Fix block structure mismatch with FINAL PREWHERE ClickHouse/ClickHouse#91847 -- backported with no changes
  2. Fix logical error on intermediate prewhere expression reuse ClickHouse/ClickHouse#90635 -- had several Antalya-specific fixes
  3. Fix exception in Parquet PREWHERE when column is not in file ClickHouse/ClickHouse#98360 -- backported with no changes

Additionally, a regression test was added. As a result, the issue similar to what #2623 fixes in 26.6 got fixed in 25.8 Antalya.

The CI is expected to fail for now. It should get better when #2571 is merged.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix incorrect query results when reading Parquet files with PREWHERE filters that compute expressions also used elsewhere in the query.

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • Aarch64 tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • CAS (content-addressed storage; Antalya only)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • OAuth (5m)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

antonio2368 and others added 4 commits October 21, 2026 17:22
Fix block structure mismatch with FINAL PREWHERE
…here_exp_fix

Fix logical error on intermediate prewhere expression reuse
…ere-external-columns

Fix exception in Parquet PREWHERE when column is not in file
Cover computed outputs, two-step row-policy filtering, and missing
physical columns with nullable and non-nullable defaults.
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Workflow [PR], commit [1246977]

@ilejn ilejn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkmkme mkmkme added the verified Approved for release label Oct 22, 2026
@mkmkme
mkmkme merged commit 77ad80b into antalya-25.8 Oct 22, 2026
242 of 243 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants