Skip to content

[PWGCF] Add histograms for purity and fraction extraction to track track task in femto framework - #18512

Merged
ariedel-cern merged 2 commits into
AliceO2Group:masterfrom
ariedel-cern:master
Oct 29, 2026
Merged

ariedel-cern merged 2 commits into
AliceO2Group:masterfrom
ariedel-cern:master

Conversation

@ariedel-cern

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ariedel-cern
ariedel-cern marked this pull request as ready for review October 29, 2026 20:02
@ariedel-cern
ariedel-cern enabled auto-merge (squash) October 29, 2026 20:02

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern
ariedel-cern merged commit 93b23d0 into AliceO2Group:master Oct 29, 2026
13 of 15 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0f81878 at 2026-10-30 01:08:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/e070ec806cd225ccefa29f65fd616947e93a8535/O2Physics-code-check/errors.txt
PWGCF/Femto/Core/trackBuilder.h:658:18: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Core/trackBuilder.h:683:87: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Core/trackBuilder.h:684:44: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Core/trackBuilder.h:690:43: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/Femto/Core/trackHistManager.h:1038:141: error: no header providing "std::hypot" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@ariedel-cern

Copy link
Copy Markdown
Collaborator Author

Code check error fixed in #18518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants