Repository navigation
Narrow the AnalysisQC gate and stop summing exit codes in the workflow tests - #2525
Merged
Merged
Conversation
The announcement claimed MC/bin changes while the execution was gated on changed_analysis_qc, so the two disagreed. Making them agree the other way ran a full sim-reco-AOD-analysis chain, about 33 minutes and a GRID token, on every MC/bin pull request. Both now follow changed_analysis_qc, which is what the execution did before. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Summing can land on a multiple of 256: two phases failing with 128 each summed to 256 and exited 0, reporting success. Keeping the first non-zero code also makes the exit status identify the phase that failed. The static guard in test/tests/ now checks that neither site sums again. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
sawenzel
requested review from
chiarazampolli,
davidrohr and
shahor02
as code owners
October 29, 2026 14:59
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AnalysisQC execution block ran on every MC/bin change, which costs about
33 minutes and a GRID token per pull request. It is back to running only for
AnalysisQC changes, as it did before.
The workflow tests also summed their phase exit codes, so two phases failing
with 128 each summed to 256 and exited 0. Both sites now keep the first
non-zero code, and the static guard in test/tests/ checks that neither sums
again.
Assisted by Claude Code.