Repository navigation
fix: confine provider credentials to their configured origin - #1904
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Provider-supplied video polling URLs and HTTP redirects could carry a provider key outside its configured origin. Provider requests now follow redirects only within the original scheme, hostname and effective port. Foreign polling/download URLs receive no provider bearer; failures name the relevant host without exposing signed URL secrets or claiming that a local boundary refusal means the key expired.
The shared policy covers completion streams, custom-compatible tool loops, media, catalog, credits and authentication requests. Caller HTTP clients retain their transport, timeouts and stricter redirect policies.
Verification
make pr-readypassed, including all touched packages; finalmake test-quickpassed.deepseek/deepseek-v4.1-flash.Fault injection uses scripted local endpoints; the live model workflow is the normal-operation control. No personal memory or real provider keys appear in the examples.
Closes #1895
Closes #1896