Skip to content

feat: immersive fullscreen and orientation api - #2919

Open
deadlyjack wants to merge 3 commits into
mainfrom
feat/fullscreen-orientation
Open

deadlyjack wants to merge 3 commits into
mainfrom
feat/fullscreen-orientation

Conversation

@deadlyjack

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added enhancement New feature or request translations Anything related to Translations Whether a Issue or PR labels Sep 20, 2026
@greptile-apps

greptile-apps Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding or newly introduced actionable defects identified.

Summary

This PR adds immersive Android browser fullscreen support and fullscreen-scoped orientation and Back-button APIs, while expanding Android shared-document handling.

  • Patches Cordova’s custom-view lifecycle during Android preparation and restores system-bar and orientation state on teardown.
  • Exposes fullscreen and orientation capabilities through the application facade, native system bridge, and TypeScript declarations.
  • Queues shared-file intents until session restoration and initial plugin loading complete, then reports unsupported or unavailable documents.
  • Adds localized messages and focused tests for fullscreen preparation, intent handling, cancellation, and session behavior.
  • The previously reported missing API declarations are now present, and that thread was manually resolved.

Diagram

sequenceDiagram
  participant Plugin as Plugin or feature
  participant API as Acode fullscreen/orientation API
  participant System as Cordova System bridge
  participant View as Cordova custom-view lifecycle
  participant Android as Android window controller
  Plugin->>API: Register Back handler or lock orientation
  API->>System: Submit fullscreen-scoped request
  System->>View: Update fullscreen controller
  View->>Android: Hide bars / apply orientation
  Android-->>View: Back or lifecycle event
  View-->>API: Dispatch fullscreen Back event
  API-->>Plugin: Invoke registered callback
  View->>Android: Restore bars and orientation on exit
Loading

Reviews (3) · Last reviewed commit: "chore: remove comments from generated fi..."

Comment thread src/lib/acode.js
@deadlyjack

Copy link
Copy Markdown
Member Author

@greptile review again

@RohitKushvaha01 RohitKushvaha01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except the hook file it could be improved for readability

Comment thread hooks/immersive-fullscreen.js Outdated
@deadlyjack

Copy link
Copy Markdown
Member Author

@greptile review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request translations Anything related to Translations Whether a Issue or PR

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants