Skip to content

fix: resolve @codemirror/lsp-client from git submodule - #2901

Merged
RohitKushvaha01 merged 4 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:fix/use-lsp-client-submodule
Sep 21, 2026
Merged

RohitKushvaha01 merged 4 commits into
Acode-Foundation:mainfrom
RohitKushvaha01:fix/use-lsp-client-submodule

Conversation

@RohitKushvaha01

@RohitKushvaha01 RohitKushvaha01 commented Sep 15, 2026

Copy link
Copy Markdown
Member
  • setup initializes the submodule before installing dependencies
  • CI checkout steps that install or build fetch submodules recursively
  • rspack treats the submodule's prebuilt dist as a dependency, not as first-party source
  • docs clone with --recurse-submodules and note the setup fallback

This is a Fix for
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/48774

npm refuses to fetch git dependencies (EALLOWGIT), which made
`npm run setup` fail before installing any dependency. The dependency
now points at the local codemirror-lsp-client submodule, pinned to the
same commit the git ref used.

- setup initializes the submodule before installing dependencies
- CI checkout steps that install or build fetch submodules recursively
- rspack treats the submodule's prebuilt dist as a dependency, not as
  first-party source
- docs clone with --recurse-submodules and note the setup fallback
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no new actionable failures identified in the changes since the previous review.

Summary

This PR moves @codemirror/lsp-client from a remote Git dependency to a pinned repository submodule and updates setup, CI, bundling, lockfiles, tests, and contributor documentation accordingly.

  • CI and nightly builds now check out submodules recursively.
  • Setup validates submodule contents before dependency installation.
  • Rspack treats the linked submodule’s prebuilt output as dependency code.
  • The latest revision strengthens partial-checkout validation and adds corresponding tests.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    Clone[Clone repository] --> Submodule[Initialize codemirror-lsp-client submodule]
    Submodule --> Setup[pnpm run setup]
    Setup --> Validate[Validate submodule root]
    Validate --> Install[Install file: dependency]
    Install --> Rspack[Rspack processes prebuilt dependency]
    Rspack --> Build[Application build]
Loading

Reviews (3) · Last reviewed commit: "fix"

Comment thread utils/setup.js Outdated
@UnschooledGamer

Copy link
Copy Markdown
Collaborator

For this, The fix will occur in next release on F-droid.

@RohitKushvaha01

Copy link
Copy Markdown
Member Author

@greptile

Comment thread utils/setup.js Outdated
@RohitKushvaha01

Copy link
Copy Markdown
Member Author

@greptile

@RohitKushvaha01
RohitKushvaha01 added this pull request to the merge queue Sep 21, 2026
Merged via the queue into Acode-Foundation:main with commit d7a1c91 Sep 21, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Sep 21, 2026
@RohitKushvaha01
RohitKushvaha01 deleted the fix/use-lsp-client-submodule branch September 21, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants