Repository navigation
Add completion spec for talosctl (Talos Linux CLI) #293
Description
Activity
Here's what I found while triaging this issue:
This appears to be a valid completion-spec feature gap:
talosctlis not currently covered by Warp command signatures. I’m labeling it as an enhancement; a maintainer can decide whether it is scoped enough for the reserved ready-to-implement gate.Maintainer details
I concluded that add native Warp command-signature coverage for the Talos Linux
talosctlCLI..Triage summary
This is an enhancement request to add Warp command-signature support for
talosctl. The currentcommand-signaturesrepo has adjacent Kubernetes CLI coverage forkubectlandhelm, plus Rust dynamic completion generators forkubectlandoc, but notalosctlJSON spec or registered dynamic generator.Reproducibility
High. Inspecting the current tree shows no
command-signatures/json/talosctl.json, notalosctlgenerator implementation, and notalosctlentry incommand-signatures/src/generators/mod.rs.Likely root cause
The requested behavior is currently unsupported because
talosctlis missing from the command-signatures package. The reporter's proposed Cobra__complete-based generator is plausible based on the existingkubectl/ocprecedent and Talos' own Cobra completion support, but the exact static command tree and dynamic completion coverage should still be verified during implementation review.Duplicate check
No matching open issues or issues closed in the last 7 days were found in
warpdotdev/command-signatures. The currently open issues cover unrelated Git, Vite+, SSH, and Make completion work.Follow-up questions
None for initial triage. The request is sufficiently scoped for an enhancement label;
ready-to-implementremains reserved for maintainers and is not applied by automated triage.This is my automated analysis and may be incorrect. A maintainer will verify the details.
Powered by Oz
- addedenhancementNew capability or improvement requestNew capability or improvement request
on Jul 16, 2026 @lucieleblanc — small label request when you get a chance.
Oz triaged this as a valid completion-spec gap and applied
enhancementon 07-16, noting thatready-to-implementis reserved for maintainers. The implementation is already up as #294 (CLA signed, checks green), but Oz won't review it until this issue carries that label, so both have been parked for two weeks.If the spec is wanted, applying
ready-to-implementhere is all that's needed — I'll comment/oz-reviewon #294 to re-trigger. Iftalosctlisn't a coverage target you want, I'm equally happy for you to close both; I'd just rather not leave the pair sitting in the queue indefinitely.@acarl005 — could you take a quick look at whether this tracking issue is scoped for
ready-to-implement?The source request, warpdotdev/warp#12693, is already labeled
ready-to-implement, and the implementation is ready in #294 (CLA signed and mergeable). Oz's only blocker is that it requires the same-repo tracking issue to carry the label before it will review the diff.If
talosctlis not a coverage target you want for this repository, closing #293 and #294 is also completely fine. A yes/no decision is all I need; no rush on reviewing the implementation itself.
Link to @that70schris's main issue: warpdotdev/warp#12693
talosctl(the Talos Linux CLI for out-of-band management of Kubernetes nodes) has no completion spec yet —command-signatures/json/covers the adjacentkubectlandhelm, but nottalosctl. Warp's Oz triage on the main issue confirmed this is a native completion feature gap and marked itready-to-implement.Since
talosctlis Cobra-based likekubectl/oc, the plan mirrors the existing precedent:talosctl_builtin_completiongenerator delegating dynamic completions (config contexts, node services, resource types,--nodes/--endpoints/--contextvalues) to the CLI's hidden Cobra__completecommand, same approach asoc_builtin_completioninoc.rsfilepaths/folderstemplates on path-like flags (--talosconfig,--file,--*-path,--*-dir, …)Implementation is ready; PR to follow. @lucieleblanc could you add
ready-to-implementwhen you get a chance (for the Oz review gate)? 🙏