Change to diagnostics upstream workaround.

dotnet/diagnostics#5791
LLVM 22 is not properly emitting asm files compiled with --noexecstack: llvm/llvm-project#186004

Author: viewizard

CMakeLists.txt

@@ -84,9 +84,6 @@ set(FEATURE_EVENT_TRACE 0)
 #   `add_executable(${ARGV} ${VERSION_FILE_PATH})` to `add_executable(${ARGV})`
 # - correct `third_party/diagnostics/src/shared/clrdefinitions.cmake`, comment line `add_custom_target(eventing_headers)`
 #   since we disable `FEATURE_EVENT_TRACE` and diagnostics don't have `eventing_headers` project in sources
-# - correct `third_party/diagnostics/src/shared/pal/src/arch/amd64/debugbreak.S`, add after header lines:
-#        // Mark this file as not requiring executable stack
-#        .section .note.GNU-stack,"",@progbits
 #
 ###
 

third_party/diagnostics/src/shared/pal/inc/unixasmmacros.inc

@@ -57,3 +57,10 @@
 #elif defined(HOST_POWERPC64)
 #include "unixasmmacrosppc64le.inc"
 #endif
+
+// Mark the stack as non-executable for ELF targets.
+// https://github.com/dotnet/runtime/issues/125469
+#if !defined(__APPLE__)
+.pushsection .note.GNU-stack,"",%progbits
+.popsection
+#endif

third_party/diagnostics/src/shared/pal/src/arch/amd64/debugbreak.S

@@ -1,9 +1,6 @@
 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
-// Mark this file as not requiring executable stack
-.section .note.GNU-stack,"",@progbits
-
 .intel_syntax noprefix
 #include "unixasmmacros.inc"