From 103f0b928c5a8db64eae43d586bbf42dec1901e0 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 18 Oct 2026 00:39:49 +0000 Subject: [PATCH 1/2] docs: fix JSDoc parameter types in `lapack/base/iladlc` Type `LDA` as `PositiveInteger` in lib/iladlc.js, matching the `LDA < max(1,s)` RangeError guard and the leading-dimension convention used in 15/17 (88%) sibling packages. Type `M` and `N` as `NonNegativeInteger` in lib/iladlc.js, lib/ndarray.js, and lib/base.js. The implementation returns `-1` for empty matrices and tests exercise `M = 0` and `N = 0`; matches 11/13 (85%) sibling matrix routines. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01P7vVhbw1EERFwQJuyT1rh8 --- lib/node_modules/@stdlib/lapack/base/iladlc/lib/base.js | 4 ++-- lib/node_modules/@stdlib/lapack/base/iladlc/lib/iladlc.js | 6 +++--- lib/node_modules/@stdlib/lapack/base/iladlc/lib/ndarray.js | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/iladlc/lib/base.js b/lib/node_modules/@stdlib/lapack/base/iladlc/lib/base.js index d1172f82b208..bc9122425cf7 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlc/lib/base.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlc/lib/base.js @@ -33,8 +33,8 @@ var iladlr = require( '@stdlib/lapack/base/iladlr' ).ndarray; * - If provided an empty matrix or a matrix containing only zeros, the function returns `-1` (i.e., an invalid index). * * @private -* @param {PositiveInteger} M - number of rows in `A` -* @param {PositiveInteger} N - number of columns in `A` +* @param {NonNegativeInteger} M - number of rows in `A` +* @param {NonNegativeInteger} N - number of columns in `A` * @param {Float64Array} A - input matrix * @param {integer} strideA1 - stride of the first dimension of `A` * @param {integer} strideA2 - stride of the second dimension of `A` diff --git a/lib/node_modules/@stdlib/lapack/base/iladlc/lib/iladlc.js b/lib/node_modules/@stdlib/lapack/base/iladlc/lib/iladlc.js index c17c0e951976..a0ad324fc841 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlc/lib/iladlc.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlc/lib/iladlc.js @@ -38,10 +38,10 @@ var base = require( './base.js' ); * - If provided an empty matrix or a matrix containing only zeros, the function returns `-1` (i.e., an invalid index). * * @param {string} order - storage layout -* @param {PositiveInteger} M - number of rows in `A` -* @param {PositiveInteger} N - number of columns in `A` +* @param {NonNegativeInteger} M - number of rows in `A` +* @param {NonNegativeInteger} N - number of columns in `A` * @param {Float64Array} A - input matrix -* @param {integer} LDA - stride of the first dimension of `A` (a.k.a., leading dimension of the matrix `A`) +* @param {PositiveInteger} LDA - stride of the first dimension of `A` (a.k.a., leading dimension of the matrix `A`) * @throws {TypeError} first argument must be a valid order * @throws {RangeError} fifth argument must be greater than or equal to max(1,N) * @returns {integer} index of the last non-zero column diff --git a/lib/node_modules/@stdlib/lapack/base/iladlc/lib/ndarray.js b/lib/node_modules/@stdlib/lapack/base/iladlc/lib/ndarray.js index c0fb9aa2baae..dbd6fa95824e 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlc/lib/ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlc/lib/ndarray.js @@ -32,8 +32,8 @@ var base = require( './base.js' ); * * - If provided an empty matrix or a matrix containing only zeros, the function returns `-1` (i.e., an invalid index). * -* @param {PositiveInteger} M - number of rows in `A` -* @param {PositiveInteger} N - number of columns in `A` +* @param {NonNegativeInteger} M - number of rows in `A` +* @param {NonNegativeInteger} N - number of columns in `A` * @param {Float64Array} A - input matrix * @param {integer} strideA1 - stride of the first dimension of `A` * @param {integer} strideA2 - stride of the second dimension of `A` From 44200e09b622c00659599a4849dfb859ecf9c79f Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 18 Oct 2026 00:39:50 +0000 Subject: [PATCH 2/2] docs: fix JSDoc parameter types in `lapack/base/iladlr` Type `LDA` as `PositiveInteger` in lib/iladlr.js, matching the `LDA < max(1,s)` RangeError guard and the leading-dimension convention used in 15/17 (88%) sibling packages. Type `M` and `N` as `NonNegativeInteger` in lib/iladlr.js, lib/ndarray.js, and lib/base.js. The implementation returns `-1` for empty matrices and tests exercise `M = 0` and `N = 0`; matches 11/13 (85%) sibling matrix routines. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01P7vVhbw1EERFwQJuyT1rh8 --- lib/node_modules/@stdlib/lapack/base/iladlr/lib/base.js | 4 ++-- lib/node_modules/@stdlib/lapack/base/iladlr/lib/iladlr.js | 6 +++--- lib/node_modules/@stdlib/lapack/base/iladlr/lib/ndarray.js | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/iladlr/lib/base.js b/lib/node_modules/@stdlib/lapack/base/iladlr/lib/base.js index 9d7e19219f13..a00dee56d6fa 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlr/lib/base.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlr/lib/base.js @@ -33,8 +33,8 @@ var isRowMajor = require( '@stdlib/ndarray/base/assert/is-row-major' ); * - If provided an empty matrix or a matrix containing only zeros, the function returns `-1` (i.e., an invalid index). * * @private -* @param {PositiveInteger} M - number of rows in `A` -* @param {PositiveInteger} N - number of columns in `A` +* @param {NonNegativeInteger} M - number of rows in `A` +* @param {NonNegativeInteger} N - number of columns in `A` * @param {Float64Array} A - input matrix * @param {integer} strideA1 - stride of the first dimension of `A` * @param {integer} strideA2 - stride of the second dimension of `A` diff --git a/lib/node_modules/@stdlib/lapack/base/iladlr/lib/iladlr.js b/lib/node_modules/@stdlib/lapack/base/iladlr/lib/iladlr.js index e5fd5893b18f..28fc34fd551d 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlr/lib/iladlr.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlr/lib/iladlr.js @@ -38,10 +38,10 @@ var base = require( './base.js' ); * - If provided an empty matrix or a matrix containing only zeros, the function returns `-1` (i.e., an invalid index). * * @param {string} order - storage layout -* @param {PositiveInteger} M - number of rows in `A` -* @param {PositiveInteger} N - number of columns in `A` +* @param {NonNegativeInteger} M - number of rows in `A` +* @param {NonNegativeInteger} N - number of columns in `A` * @param {Float64Array} A - input matrix -* @param {integer} LDA - stride of the first dimension of `A` (a.k.a., leading dimension of the matrix `A`) +* @param {PositiveInteger} LDA - stride of the first dimension of `A` (a.k.a., leading dimension of the matrix `A`) * @throws {TypeError} first argument must be a valid order * @throws {RangeError} fifth argument must be greater than or equal to max(1,N) * @returns {integer} index of the last non-zero row diff --git a/lib/node_modules/@stdlib/lapack/base/iladlr/lib/ndarray.js b/lib/node_modules/@stdlib/lapack/base/iladlr/lib/ndarray.js index 397661efa23d..2a0926ca09dd 100644 --- a/lib/node_modules/@stdlib/lapack/base/iladlr/lib/ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/iladlr/lib/ndarray.js @@ -28,8 +28,8 @@ var base = require( './base.js' ); /** * Returns the index of the last non-zero row in a matrix `A` using alternative indexing semantics. * -* @param {PositiveInteger} M - number of rows in `A` -* @param {PositiveInteger} N - number of columns in `A` +* @param {NonNegativeInteger} M - number of rows in `A` +* @param {NonNegativeInteger} N - number of columns in `A` * @param {Float64Array} A - input matrix * @param {integer} strideA1 - stride of the first dimension of `A` * @param {integer} strideA2 - stride of the second dimension of `A`