From f29d63e32ed8199a90a4f82fb8e4f3c2df049512 Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Fri, 9 Oct 2026 18:26:01 +0000 Subject: [PATCH] test: migrate `stats/incr/nanmmpe` to ULP-based assertions Replaces relative tolerance assertions with ULP difference assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of 1 ULP. Resolves a part of https://github.com/stdlib-js/stdlib/issues/11352. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_019LRi44byiqKb1zH1gx1krz --- .../@stdlib/stats/incr/nanmmpe/test/test.js | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/incr/nanmmpe/test/test.js b/lib/node_modules/@stdlib/stats/incr/nanmmpe/test/test.js index 29bf5da69012..5e66bbf66b96 100644 --- a/lib/node_modules/@stdlib/stats/incr/nanmmpe/test/test.js +++ b/lib/node_modules/@stdlib/stats/incr/nanmmpe/test/test.js @@ -22,8 +22,7 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var incrnanmmpe = require( './../lib' ); @@ -73,10 +72,8 @@ tape( 'the function returns an accumulator function', function test( t ) { tape( 'the accumulator function computes a moving mean percentage error incrementally', function test( t ) { var expected; var actual; - var delta; var data; var acc; - var tol; var N; var i; @@ -103,13 +100,7 @@ tape( 'the accumulator function computes a moving mean percentage error incremen ]; for ( i = 0; i < N; i++ ) { actual = acc( data[i][0], data[i][1] ); - if ( actual === expected[i] ) { - t.equal( actual, expected[i], 'returns expected value' ); - } else { - delta = abs( expected[i] - actual ); - tol = 1.0 * EPS * abs( expected[i] ); - t.equal( delta <= tol, true, 'within tolerance. Actual: '+actual+'. Expected: '+expected[i]+'. Delta: '+delta+'. Tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( actual, expected[i], 1 ), true, 'returns expected value' ); } t.end(); });