From 0978f78ee219c590bddbbb38d25983d4b19b9ecd Mon Sep 17 00:00:00 2001 From: Athan Reines Date: Fri, 9 Oct 2026 14:31:55 +0000 Subject: [PATCH] test: migrate `stats/base/dists/triangular/logpdf` to ULP-based assertions Replace the computed relative-tolerance comparisons in the fixture loops with `@stdlib/assert/is-almost-same-value`, using the minimum ULP bound which still passes over the full fixture set. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01C1iYP8dmC8M4qwafggaiHe --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../triangular/logpdf/test/test.factory.js | 33 +++---------------- .../triangular/logpdf/test/test.logpdf.js | 33 +++---------------- .../triangular/logpdf/test/test.native.js | 33 +++---------------- 3 files changed, 12 insertions(+), 87 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.factory.js index 98e211543d08..c3605e52c126 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.factory.js @@ -21,12 +21,11 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var ln = require( '@stdlib/math/base/special/ln' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -182,8 +181,6 @@ tape( 'if provided valid parameters, the created function returns `ln(2/(b-a))` tape( 'the created function evaluates the logpdf for `x` given small range `b - a`', function test( t ) { var expected; var logpdf; - var delta; - var tol; var a; var b; var c; @@ -199,13 +196,7 @@ tape( 'the created function evaluates the logpdf for `x` given small range `b - for ( i = 0; i < x.length; i++ ) { logpdf = factory( a[i], b[i], c[i] ); y = logpdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 40.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 55 ), true, 'returns expected value' ); } t.end(); }); @@ -213,8 +204,6 @@ tape( 'the created function evaluates the logpdf for `x` given small range `b - tape( 'the created function evaluates the logpdf for `x` given a medium range `b - a`', function test( t ) { var expected; var logpdf; - var delta; - var tol; var a; var b; var c; @@ -230,13 +219,7 @@ tape( 'the created function evaluates the logpdf for `x` given a medium range `b for ( i = 0; i < x.length; i++ ) { logpdf = factory( a[i], b[i], c[i] ); y = logpdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 60.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 76 ), true, 'returns expected value' ); } t.end(); }); @@ -244,8 +227,6 @@ tape( 'the created function evaluates the logpdf for `x` given a medium range `b tape( 'the created function evaluates the logpdf for `x` given a large range `b - a`', function test( t ) { var expected; var logpdf; - var delta; - var tol; var a; var b; var c; @@ -261,13 +242,7 @@ tape( 'the created function evaluates the logpdf for `x` given a large range `b for ( i = 0; i < x.length; i++ ) { logpdf = factory( a[i], b[i], c[i] ); y = logpdf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 50.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 83 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.logpdf.js b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.logpdf.js index d655c95aa21a..c8b0fc5930bc 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.logpdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.logpdf.js @@ -21,12 +21,11 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var ln = require( '@stdlib/math/base/special/ln' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var logpdf = require( './../lib' ); @@ -115,8 +114,6 @@ tape( 'the function returns `ln(2/(b-a))` if provided `x = c`', function test( t tape( 'the function evaluates the logpdf for `x` given a small range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -131,21 +128,13 @@ tape( 'the function evaluates the logpdf for `x` given a small range `b - a`', f c = smallRange.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], a[i], b[i], c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 40.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 55 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given a medium range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -160,21 +149,13 @@ tape( 'the function evaluates the logpdf for `x` given a medium range `b - a`', c = mediumRange.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], a[i], b[i], c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 60.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 52 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given a large range `b - a`', function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -189,13 +170,7 @@ tape( 'the function evaluates the logpdf for `x` given a large range `b - a`', f c = largeRange.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], a[i], b[i], c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 50.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 83 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.native.js index 7ce0487f86c2..a978f5808be2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/triangular/logpdf/test/test.native.js @@ -22,12 +22,11 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var ln = require( '@stdlib/math/base/special/ln' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var tryRequire = require( '@stdlib/utils/try-require' ); @@ -130,8 +129,6 @@ tape( 'the function returns `ln(2/(b-a))` if provided `x = c`', opts, function t tape( 'the function evaluates the logpdf for `x` given a small range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -146,21 +143,13 @@ tape( 'the function evaluates the logpdf for `x` given a small range `b - a`', o c = smallRange.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], a[i], b[i], c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 40.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 39 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given a medium range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -175,21 +164,13 @@ tape( 'the function evaluates the logpdf for `x` given a medium range `b - a`', c = mediumRange.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], a[i], b[i], c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 60.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 76 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function evaluates the logpdf for `x` given a large range `b - a`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var a; var b; @@ -204,13 +185,7 @@ tape( 'the function evaluates the logpdf for `x` given a large range `b - a`', o c = largeRange.c; for ( i = 0; i < x.length; i++ ) { y = logpdf( x[i], a[i], b[i], c[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', a: '+a[i]+', b: '+b[i]+', c: '+c[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 50.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. a: '+a[i]+'. b: '+b[i]+'. c: '+c[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 83 ), true, 'returns expected value' ); } t.end(); });