From eaa063935e043549048133168c4708e3f4fdb719 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 9 Aug 2026 10:21:36 +0000 Subject: [PATCH] test: migrate `stats/base/dists/hypergeometric/pmf` to ULP-based assertions Migrates the tests from computed relative tolerance assertions to ULP difference testing using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum (1967) over the full fixture set for both the JavaScript and C implementations. Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 --- .../dists/hypergeometric/pmf/test/test.factory.js | 13 ++----------- .../dists/hypergeometric/pmf/test/test.native.js | 13 ++----------- .../base/dists/hypergeometric/pmf/test/test.pmf.js | 13 ++----------- 3 files changed, 6 insertions(+), 33 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.factory.js index ac80c0737969..3a30fe0d4b95 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.factory.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var factory = require( './../lib/factory.js' ); @@ -202,9 +201,7 @@ tape( 'if provided an `n` which is not a nonnegative integer, the created functi tape( 'the created function evaluates the pmf for `x`', function test( t ) { var expected; - var delta; var pmf; - var tol; var i; var N; var K; @@ -220,13 +217,7 @@ tape( 'the created function evaluates the pmf for `x`', function test( t ) { for ( i = 0; i < x.length; i++ ) { pmf = factory( N[i], K[i], n[i] ); y = pmf( x[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1040.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1967 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.native.js index f4eff717ff94..4d50c698da2e 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.native.js @@ -23,9 +23,8 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); -var EPS = require( '@stdlib/constants/float64/eps' ); // VARIABLES // @@ -113,8 +112,6 @@ tape( 'if provided an `n` which is not a nonnegative integer, the function retur tape( 'the function evaluates the pmf for `x`', opts, function test( t ) { var expected; - var delta; - var tol; var x; var N; var K; @@ -129,13 +126,7 @@ tape( 'the function evaluates the pmf for `x`', opts, function test( t ) { n = data.n; for ( i = 0; i < x.length; i++ ) { y = pmf( x[i], N[i], K[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1040.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1967 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.pmf.js b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.pmf.js index cb752ab5e5f5..f3498b77465c 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.pmf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/test/test.pmf.js @@ -21,11 +21,10 @@ // MODULES // var tape = require( 'tape' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); var pmf = require( './../lib' ); @@ -145,8 +144,6 @@ tape( 'if provided an `n` which is not a nonnegative integer, the function retur tape( 'the function evaluates the pmf for `x`', function test( t ) { var expected; - var delta; - var tol; var x; var N; var K; @@ -161,13 +158,7 @@ tape( 'the function evaluates the pmf for `x`', function test( t ) { n = data.n; for ( i = 0; i < x.length; i++ ) { y = pmf( x[i], N[i], K[i], n[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', N: '+N[i]+', K: '+K[i]+', n: '+n[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1040.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. N: '+N[i]+'. K: '+K[i]+'. n: '+n[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1967 ), true, 'returns expected value' ); } t.end(); });