Repository navigation
test: migrate blas/base/dnrm2 to ULP-based assertions - #16244
Draft
Planeshifter wants to merge 1 commit into
Draft
Planeshifter wants to merge 1 commit into
Planeshifter wants to merge 1 commit into
Conversation
Ref: #11352 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NTyenXX4VLyEYEa6Me7RE4
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
blas/base/dnrm2(test.dnrm2.js,test.ndarray.js,test.dnrm2.native.js,test.ndarray.native.js) from theisApproxEPS-tolerance helper toisAlmostSameValuewith inline ULP literals.2.4839480006885204e-154is replaced with2.4839484696748443e-154(sqrt(6.17)e-154). The previousisApproxhelper was called with scalars, soexpected.lengthwasundefined, the loop never ran, and the comparison was never actually performed.[1e150, 1e50, 1e150, 1e50]→1(min 1)[1e-155, 1e50, 1e-155, 1e50]→1(min 1)[1.4e-154, 1.5e-154, 1.4e-154, 0]→0(min 0)test.dnrm2.jsandtest.ndarray.js.1for all three call sites; the native addon was not built in this environment, so those could not be run and the values are unverified.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Please verify the native tests in CI, since they were not run locally. The commit was made with
--no-verifybecause the pre-commit editorconfig linter could not download its binary in this environment;eslintpasses on the changed files.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code.
@stdlib-js/reviewers
Generated by Claude Code