Repository navigation
feat: add C implementation for blas/ext/base/ndarray/ztriu - #16237
AtharvaPatange wants to merge 2 commits into
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@AtharvaPatange The CI failure comes from A The scalar ndarray passed to the native add-on needs a concrete dtype, so Mind making these changes? |
|
Thanks for pointing that out! I have updated |
ujjwalv01
left a comment
There was a problem hiding this comment.
LGTM, thanks @AtharvaPatange!
Related to #14819.
Description
This pull request:
blas/ext/base/ndarray/ztriu, using the existing strided C routine.Related Issues
This pull request has the following related issues:
blas/ext/base/ndarraypackages #14819Questions
The native JS wrapper extracts k from the generic scalar ndarray and passes a float64 scalar ndarray to C, so the existing JS example works. For direct C callers, should stdlib_blas_ext_ztriu require a 0-D float64 ndarray for k, or support other numeric dtypes? Since the C function returns void, how would you prefer it to handle an unsupported dtype or unreadable scalar?
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I used codex for tests generation and documentation writing , all the changes made by ai are reviewed carefully
@stdlib-js/reviewers