Apply batched suggestions from code review

Co-authored-by: Ruben Hönle <git@hoenle.xyz>

Author: cgoetz-inovex

internal/cmd/alpha/vpc/region/create/create.go

@@ -122,7 +122,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 	return model, nil
 }
 
-func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiCreateVPCRegionRequest {
+func buildRequest(ctx context.Context, model *inputModel, apiClient iaas.DefaultAPI) iaas.ApiCreateVPCRegionRequest {
 	payload := iaas.CreateVPCRegionPayload{}
 	if model.IPv4DefaultNameservers != nil {
 		payload.Ipv4 = &iaas.RegionalVPCIPv4{

internal/cmd/alpha/vpc/region/create/create_test.go

@@ -169,15 +169,15 @@ func TestOutputResult(t *testing.T) {
 		},
 		{
 			name:   "json",
-			format: "json",
+			format: print.JSONOutputFormat,
 			resp: &iaas.RegionalVPC{
 				Status: new("CREATED"),
 			},
 			want: `"status": "CREATED"`,
 		},
 		{
 			name:   "yaml",
-			format: "yaml",
+			format: print.YAMLOutputFormat,
 			resp: &iaas.RegionalVPC{
 				Status: new("CREATED"),
 			},

internal/cmd/alpha/vpc/region/delete/delete.go

@@ -123,6 +123,6 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 	return model, nil
 }
 
-func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiDeleteVPCRegionRequest {
+func buildRequest(ctx context.Context, model *inputModel, apiClient iaas.DefaultAPI) iaas.ApiDeleteVPCRegionRequest {
 	return apiClient.DefaultAPI.DeleteVPCRegion(ctx, model.ProjectId, model.VpcId, model.Region)
 }

internal/cmd/alpha/vpc/region/describe/describe.go

@@ -101,7 +101,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 	return model, nil
 }
 
-func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiGetVPCRegionRequest {
+func buildRequest(ctx context.Context, model *inputModel, apiClient iaas.DefaultAPI) iaas.ApiGetVPCRegionRequest {
 	return apiClient.DefaultAPI.GetVPCRegion(ctx, model.ProjectId, model.VpcId, model.Region)
 }
 

internal/cmd/alpha/vpc/region/list/list.go

@@ -101,7 +101,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 	return model, nil
 }
 
-func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiListVPCRegionsRequest {
+func buildRequest(ctx context.Context, model *inputModel, apiClient iaas.DefaultAPI) iaas.ApiListVPCRegionsRequest {
 	return apiClient.DefaultAPI.ListVPCRegions(ctx, model.ProjectId, model.VpcId)
 }
 
@@ -116,7 +116,7 @@ func outputResult(p *print.Printer, outputFormat, vpcLabel string, resp *iaas.Re
 			return nil
 		}
 
-		regions := make([]string, 0, len(resp.Regions))
+		regionIds := slices.Sorted(maps.Keys(resp.Regions))
 		for region := range resp.Regions {
 			regions = append(regions, region)
 		}

internal/cmd/alpha/vpc/region/update/update.go

@@ -111,7 +111,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
 	return model, nil
 }
 
-func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiUpdateVPCRegionRequest {
+func buildRequest(ctx context.Context, model *inputModel, apiClient iaas.DefaultAPI) iaas.ApiUpdateVPCRegionRequest {
 	payload := iaas.UpdateVPCRegionPayload{
 		Ipv4: &iaas.RegionalVPCIPv4{
 			DefaultNameservers: model.IPv4DefaultNameservers,