Add convenience method to retrieve ScriptInfo/ModuleInfo from script #389

Activity

1. imagejan commented on Jun 18, 2020

   

   imagejan

   on Jun 18, 2020

   MemberAuthor

   More actions

   As we have:

   scijava-common/src/main/java/org/scijava/script/ScriptService.java

   Lines 124 to 128 in dc8ea6d

   	/**
   	* Gets the cached {@link ScriptInfo} metadata for the script at the given
   	* file, creating it if it does not already exist.
   	*/
   	ScriptInfo getScript(File scriptFile);

   already, we might want to keep it consistent and overload the getScript method like this:

   /**
    * Creates the {@link ScriptInfo} metadata for the provided script.
    */
   ScriptInfo getScript(String languageExtension, String script);

   Would you be fine with that, @ctrueden? I can submit a PR updating ScriptService and DefaultScriptService then.

   👍React with 👍1Reacted by Curtis Rueden
2. ctrueden commented on Jun 18, 2020

   

   ctrueden

   on Jun 18, 2020

   Member

   More actions

   Sounds good, @imagejan! 👍

   👍React with 👍1Reacted by Jan Eglinger
3. imagejan

   self-assigned this

   on Jun 19, 2020
4. imagejan

   added a commit that references this issue on Jun 19, 2020

   ScriptService: add getScript(String,String) signature

   ...

   This issue will close once commit 0b2e588 is merged into the 'main' branch.

   0b2e588
5. imagejan

   added a commit that references this issue on Sep 3, 2020

   ScriptService: add getScript(String,String) signature

   ...

   This issue will close once commit ab9dad2 is merged into the 'main' branch.

   ab9dad2
6. imagejan

   added a commit that references this issue on Dec 18, 2020

   ScriptService: add getScript(String,String) signature

   ...

   This issue will close once commit fc00c05 is merged into the 'main' branch.

   fc00c05
7. imagejan

   added a commit that references this issue on Jan 19, 2021

   ScriptService: add getScript(String,String) signature

   ...

   This issue will close once commit 0fc27eb is merged into the 'main' branch.

   0fc27eb