From 593a5e473bbb8a530d08178948d708f180abd1e6 Mon Sep 17 00:00:00 2001 From: Madhur Shrivastava Date: Thu, 15 Oct 2026 14:55:05 -0700 Subject: [PATCH 1/2] fix(ctcOpen): default package-manager-version to empty, not '10' Any pnpm caller whose package.json pins a different pnpm version via the packageManager field (e.g. pnpm@12.8.2) hits a hard error from pnpm/action-setup: 'Multiple versions of pnpm specified' -- because this workflow was passing version: '10' unconditionally whenever package-manager: pnpm is set, even though pnpm/action-setup already knows how to read packageManager from package.json on its own. Defaulting to an empty string lets pnpm/action-setup's own version resolution take over (it only errors when the version input is a *mismatched non-empty* value), so callers don't need to duplicate their pnpm version here and keep it in sync by hand. No other caller currently sets package-manager: pnpm, so this is a no-op for every existing workflow and only changes behavior for new pnpm adopters (fixes forcedotcom/salesforcedx-vscode's publishVSCode.yml and publishOpenVSX.yml, which previously had to work around this with an explicit package-manager-version: '' override). --- .github/workflows/ctcOpen.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ctcOpen.yml b/.github/workflows/ctcOpen.yml index e1bdacf..f42ac97 100644 --- a/.github/workflows/ctcOpen.yml +++ b/.github/workflows/ctcOpen.yml @@ -15,9 +15,9 @@ on: default: npm required: false package-manager-version: - description: pnpm version to use when package-manager is pnpm + description: pnpm version to use when package-manager is pnpm. Leave empty to let pnpm/action-setup read the "packageManager" field from the caller's package.json instead. type: string - default: '10' + default: '' required: false cache-dependency-path: description: Path to the calling repository's package manager lockfile; auto-derived from package-manager if not set From faa7720f8f7df338a7ee0f6114d8d88c094f4763 Mon Sep 17 00:00:00 2001 From: Madhur Shrivastava Date: Thu, 15 Oct 2026 19:31:46 -0700 Subject: [PATCH 2/2] fix(ctcClose): default package-manager-version to empty, not '10' Same bug as ctcOpen.yml (previous commit in this PR): defaulting to '10' forces an explicit version into pnpm/action-setup, which then conflicts with any caller's package.json packageManager field. Empty string lets it resolve the version from packageManager on its own. Confirmed needed in forcedotcom/salesforcedx-vscode's publishVSCode.yml/ publishOpenVSX.yml ctcCloseSuccess/ctcCloseFail jobs -- see forcedotcom/salesforcedx-vscode#8467. --- .github/workflows/ctcClose.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ctcClose.yml b/.github/workflows/ctcClose.yml index 1b4f73a..42c0671 100644 --- a/.github/workflows/ctcClose.yml +++ b/.github/workflows/ctcClose.yml @@ -21,9 +21,9 @@ on: default: npm required: false package-manager-version: - description: pnpm version to use when package-manager is pnpm + description: pnpm version to use when package-manager is pnpm. Leave empty to let pnpm/action-setup read the "packageManager" field from the caller's package.json instead. type: string - default: '10' + default: '' required: false cache-dependency-path: description: Path to the calling repository's package manager lockfile; auto-derived from package-manager if not set