Repository navigation
Delete gutted RCTModuleData class and its dead imports (#59426) - #59426
Closed
christophpurrer wants to merge 1 commit into
Closed
christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127228438. |
Summary: `RCTModuleData` is never instantiated and its implementation is a stub: initializers return `self`, and `gatherConstants`/`invalidate` are no-ops. Delete the header and implementation with the unused `RCTBridgeModuleProvider` typedef and `RCTModuleDataCallInvokerProvider` protocol, plus the buck header-map entry and all import sites. Changelog: [iOS][Removed] - Remove deprecated `RCTModuleData` class and its call-invoker provider protocol Differential Revision: D127228438
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D127228438
branch
from
October 24, 2026 03:19
2b80ee3 to
499edda
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 24, 2026
Summary: `RCTModuleData` is never instantiated and its implementation is a stub: initializers return `self`, and `gatherConstants`/`invalidate` are no-ops. Delete the header and implementation with the unused `RCTBridgeModuleProvider` typedef and `RCTModuleDataCallInvokerProvider` protocol, plus the buck header-map entry and all import sites. Changelog: [iOS][Removed] - Remove deprecated `RCTModuleData` class and its call-invoker provider protocol Differential Revision: D127228438
Collaborator
|
This pull request was successfully merged by @christophpurrer in f76f251 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in f76f251. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTModuleDatais never instantiated and its implementation is a stub: initializers returnself, andgatherConstants/invalidateare no-ops. Delete the header and implementation with the unusedRCTBridgeModuleProvidertypedef andRCTModuleDataCallInvokerProviderprotocol, plus the buck header-map entry and all import sites.Changelog:
[iOS][Removed] - Remove deprecated
RCTModuleDataclass and its call-invoker provider protocolDifferential Revision: D127228438