Repository navigation
Conversation
Summary: `initializePerfetto()` registers Perfetto's system backend on every platform. iOS and the other Apple device platforms have no system tracing service, so the system producer never connects and keeps retrying in the background for the app's lifetime, and a tracer in the app that starts a session without naming a backend gets the system one and records nothing. On those platforms, register the in-process backend instead. Other platforms, including macOS, are unchanged. React Native's own `ReactCxxPlatform/react/profiling/perfetto.cpp` already registers the in-process backend on every platform but Android; this change is narrower and keeps the system backend on macOS and other desktop platforms, where `traced` can run. Changelog: [Internal] Reviewed By: christophpurrer, javache Differential Revision: D126071088
meta-cla
Bot
added
the
CLA Signed
|
@potomak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126071088. |
Collaborator
|
This pull request was successfully merged by @potomak in b217ecd When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
initializePerfetto()registers Perfetto's system backend on every platform. iOS and the other Apple device platforms have no system tracing service, so the system producer never connects and keeps retrying in the background for the app's lifetime, and a tracer in the app that starts a session without naming a backend gets the system one and records nothing.On those platforms, register the in-process backend instead. Other platforms, including macOS, are unchanged. React Native's own
ReactCxxPlatform/react/profiling/perfetto.cppalready registers the in-process backend on every platform but Android; this change is narrower and keeps the system backend on macOS and other desktop platforms, wheretracedcan run.Changelog: [Internal]
Reviewed By: christophpurrer, javache
Differential Revision: D126071088