Repository navigation
Prune dead RCTBridge private declarations (#59319) - #59319
Closed
christophpurrer wants to merge 2 commits into
Closed
christophpurrer wants to merge 2 commits into
christophpurrer wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126592134. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59319 Remove bridge declarations with zero callers: profiler flow state, test-only setup, module data lookup, profiling toggles, and the unimplemented TurboModule category. The proxy keeps its shims, so runtime behavior is unchanged. Changelog: [Internal] Differential Revision: D126592134
christophpurrer
force-pushed
the
export-D126592134
branch
from
October 21, 2026 21:03
e778612 to
2250f33
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: Pull Request resolved: react#59319 Remove bridge declarations with zero callers: profiler flow state, test-only setup, module data lookup, profiling toggles, and the unimplemented TurboModule category. The proxy keeps its shims, so runtime behavior is unchanged. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126592134
christophpurrer
force-pushed
the
export-D126592134
branch
from
October 22, 2026 19:40
2250f33 to
8688bc4
Compare
Visual regressionNo visual differences at |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 23, 2026
Summary: Remove bridge declarations with zero callers: profiler flow state, test-only setup, module data lookup, profiling toggles, and the unimplemented TurboModule category. The proxy keeps its shims, so runtime behavior is unchanged. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126592134
christophpurrer
force-pushed
the
export-D126592134
branch
from
October 23, 2026 04:01
8688bc4 to
7f6b3da
Compare
Summary: RCTProfile hooked bridge modules for systrace capture, driven only by the deleted legacy bridge. With all call sites migrated or removed, delete the header, implementation, trampolines, and remaining hooks in the display link, module methods, performance logger, and downstream systrace callers. Changelog: [iOS][Removed] - Remove deprecated RCTProfile systrace API Reviewed By: shwanton Differential Revision: D126581734
Summary: Remove bridge declarations with zero callers: profiler flow state, test-only setup, module data lookup, profiling toggles, and the unimplemented TurboModule category. The proxy keeps its shims, so runtime behavior is unchanged. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126592134
christophpurrer
force-pushed
the
export-D126592134
branch
from
October 23, 2026 14:51
7f6b3da to
ea5106a
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in 1ca5679 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove bridge declarations with zero callers: profiler flow state,
test-only setup, module data lookup, profiling toggles, and the
unimplemented TurboModule category. The proxy keeps its shims, so
runtime behavior is unchanged.
Changelog:
[Internal]
Reviewed By: shwanton
Differential Revision: D126592134