Make remaining ReactNative and Core modules Flow strict-local (#57730)

Summary:

Upgrade the remaining ReactNative and Core modules from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D113763791

Author: rubennorte

packages/react-native/Libraries/Core/Timers/JSTimers.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  * @deprecated
  */
@@ -29,13 +29,15 @@ export type JSTimerType =
   | 'queueReactNativeMicrotask'
   | 'requestIdleCallback';
 
+type TimerFunc = (...args: Array<unknown>) => unknown;
+
 // These timing constants should be kept in sync with the ones in native ios and
 // android `RCTTiming` module.
 const FRAME_DURATION = 1000 / 60;
 const IDLE_CALLBACK_FRAME_DEADLINE = 1;
 
 // Parallel arrays
-const callbacks: Array<?Function> = [];
+const callbacks: Array<?TimerFunc> = [];
 const types: Array<?JSTimerType> = [];
 const timerIDs: Array<?number> = [];
 const freeIdxs: Array<number> = [];
@@ -57,7 +59,7 @@ function _getFreeIndex(): number {
   return freeIdx;
 }
 
-function _allocateCallback(func: Function, type: JSTimerType): number {
+function _allocateCallback(func: TimerFunc, type: JSTimerType): number {
   const id = GUID++;
   const freeIndex = _getFreeIndex();
   timerIDs[freeIndex] = id;
@@ -210,9 +212,9 @@ const JSTimers = {
    * @param {number} duration Number of milliseconds.
    */
   setTimeout: function (
-    func: Function,
+    func: TimerFunc,
     duration: number,
-    ...args: any
+    ...args: Array<unknown>
   ): number {
     const id = _allocateCallback(
       () => func.apply(undefined, args),
@@ -227,9 +229,9 @@ const JSTimers = {
    * @param {number} duration Number of milliseconds.
    */
   setInterval: function (
-    func: Function,
+    func: TimerFunc,
     duration: number,
-    ...args: any
+    ...args: Array<unknown>
   ): number {
     const id = _allocateCallback(
       () => func.apply(undefined, args),
@@ -247,7 +249,10 @@ const JSTimers = {
    * @param {function} func Callback to be invoked before the end of the
    * current JavaScript execution loop.
    */
-  queueReactNativeMicrotask: function (func: Function, ...args: any): number {
+  queueReactNativeMicrotask: function (
+    func: TimerFunc,
+    ...args: Array<unknown>
+  ): number {
     const id = _allocateCallback(
       () => func.apply(undefined, args),
       'queueReactNativeMicrotask',
@@ -259,7 +264,7 @@ const JSTimers = {
   /**
    * @param {function} func Callback to be invoked every frame.
    */
-  requestAnimationFrame: function (func: Function): any | number {
+  requestAnimationFrame: function (func: TimerFunc): number {
     const id = _allocateCallback(func, 'requestAnimationFrame');
     createTimer(id, 1, Date.now(), /* recurring */ false);
     return id;
@@ -271,17 +276,17 @@ const JSTimers = {
    * @param {?object} options
    */
   requestIdleCallback: function (
-    func: Function,
-    options: ?Object,
-  ): any | number {
+    func: TimerFunc,
+    options: ?{timeout?: number, ...},
+  ): number {
     if (requestIdleCallbacks.length === 0) {
       setSendIdleEvents(true);
     }
 
     const timeout = options && options.timeout;
     const id: number = _allocateCallback(
       timeout != null
-        ? (deadline: any) => {
+        ? (deadline: unknown) => {
             const timeoutId: number = requestIdleCallbackTimeouts[id];
             if (timeoutId) {
               JSTimers.clearTimeout(timeoutId);
@@ -353,7 +358,7 @@ const JSTimers = {
    * This is called from the native side. We are passed an array of timerIDs,
    * and
    */
-  callTimers: function (timersToCall: Array<number>): any | void {
+  callTimers: function (timersToCall: Array<number>): void {
     invariant(
       timersToCall.length !== 0,
       'Cannot call `callTimers` with an empty list of IDs.',
@@ -458,20 +463,34 @@ function setSendIdleEvents(sendIdleEvents: boolean): void {
 }
 
 let ExportedJSTimers: {
-  callIdleCallbacks: (frameTime: number) => any | void,
+  callIdleCallbacks: (frameTime: number) => void,
   callReactNativeMicrotasks: () => void,
-  callTimers: (timersToCall: Array<number>) => any | void,
+  callTimers: (timersToCall: Array<number>) => void,
   cancelAnimationFrame: (timerID: number) => void,
   cancelIdleCallback: (timerID: number) => void,
   clearReactNativeMicrotask: (timerID: number) => void,
   clearInterval: (timerID: number) => void,
   clearTimeout: (timerID: number) => void,
-  emitTimeDriftWarning: (warningMessage: string) => any | void,
-  requestAnimationFrame: (func: any) => any | number,
-  requestIdleCallback: (func: any, options: ?any) => any | number,
-  queueReactNativeMicrotask: (func: any, ...args: any) => number,
-  setInterval: (func: any, duration: number, ...args: any) => number,
-  setTimeout: (func: any, duration: number, ...args: any) => number,
+  emitTimeDriftWarning: (warningMessage: string) => void,
+  requestAnimationFrame: (func: TimerFunc) => number,
+  requestIdleCallback: (
+    func: TimerFunc,
+    options: ?{timeout?: number, ...},
+  ) => number,
+  queueReactNativeMicrotask: (
+    func: TimerFunc,
+    ...args: Array<unknown>
+  ) => number,
+  setInterval: (
+    func: TimerFunc,
+    duration: number,
+    ...args: Array<unknown>
+  ) => number,
+  setTimeout: (
+    func: TimerFunc,
+    duration: number,
+    ...args: Array<unknown>
+  ) => number,
 };
 
 if (!NativeTiming) {

packages/react-native/Libraries/Core/setUpReactDevTools.js

@@ -4,13 +4,16 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
 'use strict';
 
-import type {Domain} from '../../src/private/devsupport/rndevtools/setUpFuseboxReactDevToolsDispatcher';
+import type {
+  Domain,
+  JSONValue,
+} from '../../src/private/devsupport/rndevtools/setUpFuseboxReactDevToolsDispatcher';
 import type {Spec as NativeReactDevToolsRuntimeSettingsModuleSpec} from '../../src/private/devsupport/rndevtools/specs/NativeReactDevToolsRuntimeSettingsModule';
 
 if (__DEV__) {
@@ -35,6 +38,7 @@ if (__DEV__) {
   const {
     initialize,
     connectWithCustomMessagingProtocol,
+    // $FlowFixMe[untyped-import]
   } = require('react-devtools-core');
 
   const reactDevToolsSettingsManager = require('../../src/private/devsupport/rndevtools/ReactDevToolsSettingsManager');
@@ -73,7 +77,7 @@ if (__DEV__) {
     require('../Components/View/ReactNativeStyleAttributes').default;
   const resolveRNStyle = require('../StyleSheet/flattenStyle').default;
 
-  function handleReactDevToolsSettingsUpdate(settings: Object) {
+  function handleReactDevToolsSettingsUpdate(settings: {[string]: unknown}) {
     reactDevToolsSettingsManager.setGlobalHookSettings(
       JSON.stringify(settings),
     );
@@ -97,13 +101,13 @@ if (__DEV__) {
       maybeReactDevToolsRuntimeSettingsModuleModule,
     );
     disconnect = connectWithCustomMessagingProtocol({
-      onSubscribe: listener => {
+      onSubscribe: (listener: (message: JSONValue) => void) => {
         domain.onMessage.addEventListener(listener);
       },
-      onUnsubscribe: listener => {
+      onUnsubscribe: (listener: (message: JSONValue) => void) => {
         domain.onMessage.removeEventListener(listener);
       },
-      onMessage: (event, payload) => {
+      onMessage: (event: string, payload: JSONValue) => {
         domain.sendMessage({event, payload});
       },
       nativeStyleEditorValidAttributes: Object.keys(ReactNativeStyleAttributes),

packages/react-native/Libraries/Core/setUpReactRefresh.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -18,6 +18,7 @@ if (__DEV__) {
   }
 
   // This needs to run before the renderer initializes.
+  // $FlowFixMe[untyped-import]
   const ReactRefreshRuntime = require('react-refresh/runtime');
   ReactRefreshRuntime.injectIntoGlobalHook(global);
 

packages/react-native/Libraries/ReactNative/AppContainer.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -17,6 +17,7 @@ export type Props = Readonly<{
   children?: React.Node,
   rootTag: number | RootTag,
   initialProps?: {...},
+  // $FlowFixMe[unclear-type]
   WrapperComponent?: ?React.ComponentType<any>,
   rootViewStyle?: ?ViewStyleProp,
   internal_excludeLogBox?: boolean,

packages/react-native/Libraries/ReactNative/AppRegistry.flow.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -13,13 +13,16 @@ import type {RootTag} from '../Types/RootTagTypes';
 import type {DisplayModeType} from './DisplayMode';
 import type {IPerformanceLogger} from './IPerformanceLogger.flow';
 
+// $FlowFixMe[unclear-type]
 type HeadlessTask = (taskData: any) => Promise<void>;
 export type TaskProvider = () => HeadlessTask;
 
+// $FlowFixMe[unclear-type]
 export type ComponentProvider = () => React.ComponentType<any>;
 export type ComponentProviderInstrumentationHook = (
   component_: ComponentProvider,
   scopedPerformanceLogger: IPerformanceLogger,
+  // $FlowFixMe[unclear-type]
 ) => React.ComponentType<any>;
 export type AppConfig = {
   appKey: string,
@@ -43,7 +46,10 @@ export type Registry = {
   ...
 };
 export type WrapperComponentProvider = (
-  appParameters: Object,
+  appParameters?: AppParameters,
   appKey?: string,
+  // $FlowFixMe[unclear-type]
 ) => React.ComponentType<any>;
-export type RootViewStyleProvider = (appParameters: Object) => ViewStyleProp;
+export type RootViewStyleProvider = (
+  appParameters: AppParameters,
+) => ViewStyleProp;