Make assorted remaining modules Flow strict-local (#57737)

Summary:
Pull Request resolved: #57737

Upgrade the remaining assorted modules (Touchable pooling, ActionSheetIOS, Alert, LogBox highlight, Text native component, PushNotificationIOS) from `flow` to `flow strict-local`, preserving public type signatures so consumers are unaffected. Genuinely-dynamic internal `any` usages are marked with scoped `$FlowFixMe[unclear-type]` where an accurate type cannot be expressed.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D113763783

Author: rubennorte

packages/react-native/Libraries/ActionSheetIOS/ActionSheetIOS.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -49,6 +49,7 @@ export type ShareActionSheetIOSOptions = Readonly<{
 export type ShareActionSheetError = Readonly<{
   domain: string,
   code: string,
+  // $FlowFixMe[unclear-type]
   userInfo?: ?Object,
   message: string,
 }>;
@@ -155,7 +156,9 @@ const ActionSheetIOS = {
    */
   showShareActionSheetWithOptions(
     options: ShareActionSheetIOSOptions,
+    // $FlowFixMe[unclear-type]
     failureCallback: Function | ((error: ShareActionSheetError) => void),
+    // $FlowFixMe[unclear-type]
     successCallback: Function | ((success: boolean, method: ?string) => void),
   ) {
     invariant(

packages/react-native/Libraries/Alert/Alert.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -26,6 +26,7 @@ export type AlertButtonStyle = 'default' | 'cancel' | 'destructive';
 
 export type AlertButton = {
   text?: string,
+  // $FlowFixMe[unclear-type]
   onPress?: ?((value?: string) => any) | ?Function,
   isPreferred?: boolean,
   style?: AlertButtonStyle,
@@ -121,7 +122,7 @@ class Alert {
         cancelable: false,
       };
 
-      if (options && options.cancelable) {
+      if (options != null && options.cancelable === true) {
         config.cancelable = options.cancelable;
       }
       // At most three buttons (neutral, negative, positive). Ignore rest.
@@ -141,25 +142,20 @@ class Alert {
         config.buttonNegative = buttonNegative.text || '';
       }
       if (buttonPositive) {
-        config.buttonPositive = buttonPositive.text || defaultPositiveText;
+        config.buttonPositive =
+          buttonPositive.text != null && buttonPositive.text !== ''
+            ? buttonPositive.text
+            : defaultPositiveText;
       }
 
-      /* $FlowFixMe[missing-local-annot] The type annotation(s) required by
-       * Flow's LTI update could not be added via codemod */
-      const onAction = (action, buttonKey) => {
+      const onAction = (action: string, buttonKey?: number) => {
         if (action === constants.buttonClicked) {
           if (buttonKey === constants.buttonNeutral) {
-            // $FlowFixMe[incompatible-type]
-            // $FlowFixMe[incompatible-use]
-            buttonNeutral.onPress && buttonNeutral.onPress();
+            buttonNeutral?.onPress?.();
           } else if (buttonKey === constants.buttonNegative) {
-            // $FlowFixMe[incompatible-type]
-            // $FlowFixMe[incompatible-use]
-            buttonNegative.onPress && buttonNegative.onPress();
+            buttonNegative?.onPress?.();
           } else if (buttonKey === constants.buttonPositive) {
-            // $FlowFixMe[incompatible-type]
-            // $FlowFixMe[incompatible-use]
-            buttonPositive.onPress && buttonPositive.onPress();
+            buttonPositive?.onPress?.();
           }
         } else if (action === constants.dismissed) {
           options && options.onDismiss && options.onDismiss();
@@ -186,7 +182,7 @@ class Alert {
     options?: AlertOptions,
   ): void {
     if (Platform.OS === 'ios') {
-      let callbacks: Array<?any> = [];
+      let callbacks: Array<?(value: string) => unknown> = [];
       const buttons = [];
       let cancelButtonKey;
       let destructiveButtonKey;
@@ -195,16 +191,20 @@ class Alert {
         callbacks = [callbackOrButtons];
       } else if (Array.isArray(callbackOrButtons)) {
         callbackOrButtons.forEach((btn, index) => {
-          callbacks[index] = btn.onPress;
+          callbacks[index] =
+            btn.onPress == null ? null : value => btn.onPress?.(value);
           if (btn.style === 'cancel') {
             cancelButtonKey = String(index);
           } else if (btn.style === 'destructive') {
             destructiveButtonKey = String(index);
           }
-          if (btn.isPreferred) {
+          if (btn.isPreferred === true) {
             preferredButtonKey = String(index);
           }
-          if (btn.text || index < (callbackOrButtons || []).length - 1) {
+          if (
+            (btn.text != null && btn.text !== '') ||
+            index < callbackOrButtons.length - 1
+          ) {
             const btnDef: {[number]: string} = {};
             btnDef[index] = btn.text || '';
             buttons.push(btnDef);
@@ -215,7 +215,7 @@ class Alert {
       alertWithArgs(
         {
           title: title || '',
-          message: message || undefined,
+          message: message != null && message !== '' ? message : undefined,
           buttons,
           type: type || undefined,
           defaultValue,

packages/react-native/Libraries/Components/Touchable/PooledClass.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -20,6 +20,7 @@ import invariant from 'invariant';
  */
 /* $FlowFixMe[missing-this-annot] The 'this' type annotation(s) required by
  * Flow's LTI update could not be added via codemod */
+// $FlowFixMe[unclear-type]
 const oneArgumentPooler = function (copyFieldsFrom: any) {
   const Klass = this; // eslint-disable-line consistent-this
   if (Klass.instancePool.length) {
@@ -33,6 +34,7 @@ const oneArgumentPooler = function (copyFieldsFrom: any) {
 
 /* $FlowFixMe[missing-this-annot] The 'this' type annotation(s) required by
  * Flow's LTI update could not be added via codemod */
+// $FlowFixMe[unclear-type]
 const twoArgumentPooler = function (a1: any, a2: any) {
   const Klass = this; // eslint-disable-line consistent-this
   if (Klass.instancePool.length) {
@@ -46,6 +48,7 @@ const twoArgumentPooler = function (a1: any, a2: any) {
 
 /* $FlowFixMe[missing-this-annot] The 'this' type annotation(s) required by
  * Flow's LTI update could not be added via codemod */
+// $FlowFixMe[unclear-type]
 const threeArgumentPooler = function (a1: any, a2: any, a3: any) {
   const Klass = this; // eslint-disable-line consistent-this
   if (Klass.instancePool.length) {
@@ -59,6 +62,7 @@ const threeArgumentPooler = function (a1: any, a2: any, a3: any) {
 
 /* $FlowFixMe[missing-this-annot] The 'this' type annotation(s) required by
  * Flow's LTI update could not be added via codemod */
+// $FlowFixMe[unclear-type]
 const fourArgumentPooler = function (a1: any, a2: any, a3: any, a4: any) {
   const Klass = this; // eslint-disable-line consistent-this
   if (Klass.instancePool.length) {
@@ -89,6 +93,7 @@ const standardReleaser = function (instance) {
 const DEFAULT_POOL_SIZE = 10;
 const DEFAULT_POOLER = oneArgumentPooler;
 
+// $FlowFixMe[unclear-type]
 type Pooler = any;
 
 /**
@@ -112,6 +117,7 @@ const addPoolingTo = function <T>(
 } {
   // Casting as any so that flow ignores the actual implementation and trusts
   // it to match the type we declared
+  // $FlowFixMe[unclear-type]
   const NewKlass: any = CopyConstructor;
   NewKlass.instancePool = [];
   NewKlass.getPooled = pooler || DEFAULT_POOLER;

packages/react-native/Libraries/LogBox/UI/AnsiHighlight.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -13,6 +13,7 @@ import type {TextStyleProp} from '../../StyleSheet/StyleSheet';
 import View from '../../Components/View/View';
 import StyleSheet from '../../StyleSheet/StyleSheet';
 import Text from '../../Text/Text';
+// $FlowFixMe[untyped-import]
 import {ansiToJson} from 'anser';
 import * as React from 'react';
 

packages/react-native/Libraries/PushNotificationIOS/PushNotificationIOS.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -28,6 +28,7 @@ type PresentLocalNotificationDetails = {
   alertTitle?: string,
   soundName?: string,
   category?: string,
+  // $FlowFixMe[unclear-type]
   userInfo?: Object,
   applicationIconBadgeNumber?: number,
   fireDate?: number,
@@ -122,6 +123,7 @@ export interface PushNotification {
   /**
    * An alias for `getAlert` to get the notification's main message string
    */
+  // $FlowFixMe[unclear-type]
   getMessage(): ?string | ?Object;
 
   /**
@@ -137,6 +139,7 @@ export interface PushNotification {
   /**
    * Gets the notification's main message from the `aps` object
    */
+  // $FlowFixMe[unclear-type]
   getAlert(): ?string | ?Object;
 
   /**
@@ -152,6 +155,7 @@ export interface PushNotification {
   /**
    * Gets the data object on the notif
    */
+  // $FlowFixMe[unclear-type]
   getData(): ?Object;
 
   /**
@@ -174,7 +178,9 @@ export interface PushNotification {
  * @deprecated Use [@react-native-community/push-notification-ios](https://www.npmjs.com/package/@react-native-community/push-notification-ios) instead
  */
 class PushNotificationIOS {
+  // $FlowFixMe[unclear-type]
   _data: Object;
+  // $FlowFixMe[unclear-type]
   _alert: string | Object;
   _sound: string;
   _category: string;
@@ -276,6 +282,7 @@ class PushNotificationIOS {
    * See https://reactnative.dev/docs/pushnotificationios#getdeliverednotifications
    */
   static getDeliveredNotifications(
+    // $FlowFixMe[unclear-type]
     callback: (notifications: Array<Object>) => void,
   ): void {
     invariant(
@@ -316,6 +323,7 @@ class PushNotificationIOS {
    *
    * See https://reactnative.dev/docs/pushnotificationios#getapplicationiconbadgenumber
    */
+  // $FlowFixMe[unclear-type]
   static getApplicationIconBadgeNumber(callback: Function): void {
     invariant(
       NativePushNotificationManagerIOS,
@@ -330,6 +338,7 @@ class PushNotificationIOS {
    *
    * See https://reactnative.dev/docs/pushnotificationios#cancellocalnotification
    */
+  // $FlowFixMe[unclear-type]
   static cancelLocalNotifications(userInfo: Object): void {
     invariant(
       NativePushNotificationManagerIOS,
@@ -343,6 +352,7 @@ class PushNotificationIOS {
    *
    * See https://reactnative.dev/docs/pushnotificationios#getscheduledlocalnotifications
    */
+  // $FlowFixMe[unclear-type]
   static getScheduledLocalNotifications(callback: Function): void {
     invariant(
       NativePushNotificationManagerIOS,
@@ -359,6 +369,7 @@ class PushNotificationIOS {
    */
   static addEventListener(
     type: PushNotificationEventName,
+    // $FlowFixMe[unclear-type]
     handler: Function,
   ): void {
     invariant(
@@ -539,6 +550,7 @@ class PushNotificationIOS {
    * `getInitialNotification` is sufficient.
    *
    */
+  // $FlowFixMe[unclear-type]
   constructor(nativeNotif: Object) {
     this._data = {};
     this._remoteNotificationCompleteCallbackCalled = false;
@@ -603,6 +615,7 @@ class PushNotificationIOS {
   /**
    * An alias for `getAlert` to get the notification's main message string.
    */
+  // $FlowFixMe[unclear-type]
   getMessage(): ?string | ?Object {
     // alias because "alert" is an ambiguous name
     return this._alert;
@@ -633,6 +646,7 @@ class PushNotificationIOS {
    *
    * See https://reactnative.dev/docs/pushnotificationios#getalert
    */
+  // $FlowFixMe[unclear-type]
   getAlert(): ?string | ?Object {
     return this._alert;
   }
@@ -660,6 +674,7 @@ class PushNotificationIOS {
    *
    * See https://reactnative.dev/docs/pushnotificationios#getdata
    */
+  // $FlowFixMe[unclear-type]
   getData(): ?Object {
     return this._data;
   }

packages/react-native/Libraries/Text/TextNativeComponent.js

@@ -4,7 +4,7 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  *
- * @flow
+ * @flow strict-local
  * @format
  */
 
@@ -77,23 +77,31 @@ const virtualTextViewConfig = {
 // Additional note: Our long term plan is to reduce the overhead of the <Text>
 // and <View> wrappers so that we no longer have any reason to export these APIs.
 export const NativeText: HostComponent<NativeTextProps> =
-  createReactNativeComponentClass('RCTText', () =>
-    createViewConfig(textViewConfig),
+  createReactNativeComponentClass(
+    'RCTText',
+    () => createViewConfig(textViewConfig),
+    // $FlowFixMe[unclear-type]
   ) as any;
 
 export const NativeVirtualText: HostComponent<NativeTextProps> =
-  !global.RN$Bridgeless && !UIManager.hasViewManagerConfig('RCTVirtualText')
+  global.RN$Bridgeless !== true &&
+  !UIManager.hasViewManagerConfig('RCTVirtualText')
     ? NativeText
-    : (createReactNativeComponentClass('RCTVirtualText', () =>
-        createViewConfig(virtualTextViewConfig),
+    : (createReactNativeComponentClass(
+        'RCTVirtualText',
+        () => createViewConfig(virtualTextViewConfig),
+        // $FlowFixMe[unclear-type]
       ) as any);
 
 export const NativeSelectableText: HostComponent<NativeTextProps> =
   enablePreparedTextLayout()
-    ? (createReactNativeComponentClass('RCTSelectableText', () =>
-        createViewConfig({
-          ...textViewConfig,
-          uiViewClassName: 'RCTSelectableText',
-        }),
+    ? (createReactNativeComponentClass(
+        'RCTSelectableText',
+        () =>
+          createViewConfig({
+            ...textViewConfig,
+            uiViewClassName: 'RCTSelectableText',
+          }),
+        // $FlowFixMe[unclear-type]
       ) as any)
     : NativeText;