diff --git a/news/changelog-1.11.md b/news/changelog-1.11.md index f57f1c17c8e..ba13a185842 100644 --- a/news/changelog-1.11.md +++ b/news/changelog-1.11.md @@ -56,6 +56,7 @@ All changes included in 1.11: - ([#14996](https://github.com/quarto-dev/quarto-cli/pull/14996)): Fix `controls: auto` and `previewLinks: auto` set at the top level of a revealjs document's front matter producing a presentation that fails to load, because `auto` was written unquoted into the generated JavaScript. - ([#15007](https://github.com/quarto-dev/quarto-cli/pull/15007)): Fix Home/End on a focused tabset tab also jumping to the first or last slide in addition to switching tabs. - ([#15014](https://github.com/quarto-dev/quarto-cli/issues/15014)): Fix code blocks at the end of a callout losing their bottom spacing, which made the code block border touch the callout border in untitled `appearance="simple"` callouts (regression introduced in v1.8.15). +- ([#15037](https://github.com/quarto-dev/quarto-cli/pull/15037)): Fix `dracula` theme coloring a `` in a callout title with the theme's bold color, unlike ``. ### `typst` diff --git a/package/src/common/patches/revealjs-theme-0001-dracula.patch b/package/src/common/patches/revealjs-theme-0001-dracula.patch index fe2d7d0e07e..9bb10e68b04 100644 --- a/package/src/common/patches/revealjs-theme-0001-dracula.patch +++ b/package/src/common/patches/revealjs-theme-0001-dracula.patch @@ -151,7 +151,7 @@ index 5330fbc1b..fe068d9a8 100644 - } + strong, + b { -+ &:not(.callout-title strong, .callout-tile b) { ++ &:not(.callout-title strong, .callout-title b) { + color: var(--r-bold-color); + } + } diff --git a/src/resources/formats/revealjs/themes/dracula.scss b/src/resources/formats/revealjs/themes/dracula.scss index fe068d9a8d1..1bb2cd96f51 100644 --- a/src/resources/formats/revealjs/themes/dracula.scss +++ b/src/resources/formats/revealjs/themes/dracula.scss @@ -59,7 +59,7 @@ $light-bg-text-color: $body-bg !default; .reveal { strong, b { - &:not(.callout-title strong, .callout-tile b) { + &:not(.callout-title strong, .callout-title b) { color: var(--r-bold-color); } } diff --git a/tests/docs/playwright/revealjs/callouts/dracula-theme-tweaks.qmd b/tests/docs/playwright/revealjs/callouts/dracula-theme-tweaks.qmd index 32105f3f31c..dc87d0a9c4c 100644 --- a/tests/docs/playwright/revealjs/callouts/dracula-theme-tweaks.qmd +++ b/tests/docs/playwright/revealjs/callouts/dracula-theme-tweaks.qmd @@ -17,3 +17,13 @@ So we tweaked dracula theme et this test checks that color of title is like in o Content ::: + +## Bold in title + +::: {.callout-note} + +## Title with raw b and **strong** + +Content with bold + +::: diff --git a/tests/integration/playwright/tests/revealjs-themes.spec.ts b/tests/integration/playwright/tests/revealjs-themes.spec.ts index dc3f53e9fd3..0b57a1dcc53 100644 --- a/tests/integration/playwright/tests/revealjs-themes.spec.ts +++ b/tests/integration/playwright/tests/revealjs-themes.spec.ts @@ -80,6 +80,14 @@ test('Callout title color in dracula theme is correctly tweaked to use same as b await checkColorIdentical(calloutTitleLoc, calloutContentLoc, 'color'); }); +test('Bold elements inside callout title in dracula theme use same color as body', async ({ page }) => { + await page.goto('./revealjs/callouts/dracula-theme-tweaks.html#/bold-in-title'); + const calloutTitleLoc = page.locator('#bold-in-title .callout-title'); + const calloutContentLoc = page.getByText('Content with bold', { exact: true }); + await checkColorIdentical(calloutTitleLoc.locator('b'), calloutContentLoc, 'color'); + await checkColorIdentical(calloutTitleLoc.locator('strong strong'), calloutContentLoc, 'color'); +}); + test('Headings color in simple and serif theme are correctly defaulting to $body-bg', async ({ page }) => { await page.goto('./revealjs/heading-color/simple.html#/slide-1'); await checkColorIdentical(