Repository navigation
ext/readline: Fix non-ASCII completion append characters in readline_info() - #24263
Closed
LamentXU123 wants to merge 1 commit into
Closed
LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
Store the first byte as unsigned char to keep completion_append_character within the valid range of the one-character string table.
LamentXU123
added a commit
that referenced
this pull request
Oct 12, 2026
* PHP-8.6: ext/readline: Fix non-ASCII completion append characters in readline_info() (#24263)
Member
Author
|
Thanks! |
StephenWall
pushed a commit
to StephenWall/php-src
that referenced
this pull request
Oct 12, 2026
* PHP-8.4: ext/readline: Fix non-ASCII completion append characters in readline_info() (php#24263)
StephenWall
pushed a commit
to StephenWall/php-src
that referenced
this pull request
Oct 12, 2026
* PHP-8.5: ext/readline: Fix non-ASCII completion append characters in readline_info() (php#24263)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought this was a typo initially and I was intended to fix this as a refactor, but it comes out this can cause bugs. This shouldn't be negative.