update monorepo integration

Author: justincorrigible

.dev/sessions.md

@@ -16,12 +16,24 @@ Newest first.
 - Added tech-debt entry for `setup.md` referencing `.env.arrangerDev` which no longer exists — left unfixed as the correct replacement process is unclear.
 - Added three tech-debt entries under `## apps/mcp-server` in `tech-debt.md`: `InMemoryEventStore` not suitable for production (persistent store needed before production deployment); MCP session map does not evict abandoned transports (timestamp-based sweep approach noted); introspection types should be Zod-first so MCP output schemas can import directly from `search-server` rather than duplicating locally
 - Updated `sessions.md` protocol in `~/.claude/CLAUDE.md`, `CLAUDE.md`, `AGENTS.md`, `.github/copilot-instructions.md`, and memory: `sessions.md` records only changes to code or working documents, not conversational activity
+- Renamed Docker stage `server` → `search-server` in both Dockerfiles — removes ambiguity now that two server images exist
+- Rewrote `jenkins-pipeline-library/vars/pipelineOvertureArranger.groovy` (Phase 2 CI/CD work):
+    - `turboBase` computed once from `GIT_PREVIOUS_COMMIT` (the commit Jenkins last built on this branch) with `HEAD^1` fallback for first builds — correctly covers multi-commit pushes to any branch, including direct pushes to main, without needing branch-specific logic; used for all change detection throughout the pipeline
+    - Turbo build with `--filter=[turboBase]` replaces `npm run modules:build`; only affected packages and their dependents build
+    - Turbo test with `--filter=[turboBase]` replaces five individual `npm run test -w` calls; `integration-tests/server` and `integration-tests/mcp-server` excluded from Turbo and handled separately
+    - `integration-tests/server` runs conditionally — only when files in `sqon`, `types`, `graphql-router`, `apps/search-server`, or `integration-tests/server` changed since `turboBase`
+    - Docker builds conditional per image: `search-server` image rebuilds when its server chain or Dockerfile changes; `mcp-server` image rebuilds when `apps/mcp-server`, shared modules, or Dockerfile changes; `POST_BUILD: Publish` parameter overrides and builds both
+    - App versions (`searchServerVersion`, `mcpServerVersion`) read directly from `apps/*/package.json` in the Build stage — fixes pre-existing null bug where `versionsMap['server']` was used but `versionsMap` only covered `modules/*`
+    - `TURBO_TELEMETRY_DISABLED=1` added to environment block
+    - TEMP `release-charts` stage removed; `modules/charts` now covered by the standard release publish loop
+    - Dead commented-out Slack notification code removed
 
 **Decisions:**
 
 - `fieldShape` outputSchema without `.parse()` is correct MCP usage — `outputSchema` is declarative for MCP clients, not runtime-enforced by the SDK
 - Session eviction approach for `apps/mcp-server/src/http/app.ts`: track `lastSeenAt` per transport entry, sweep via `setInterval`, close and evict sessions idle beyond a configurable TTL (e.g. 30 min)
 - `integration-tests/mcp-server` excluded from CI pipeline for now — needs full stack (ES + Arranger server + MCP server); design deferred
+- `Deploy to overture-dev` stage left unchanged — infrastructure config for `arranger-iobio` must be updated separately to use the renamed `arranger-search-server` image
 
 **Open threads:**
 
@@ -34,6 +46,9 @@ Newest first.
 
 **Done:**
 
+- Removed `docker/**` and `docker-compose.yml` from `turbo.json` globalDependencies — those files don't affect TypeScript source so they were causing unnecessary cache busting; `tsconfig.eslint.json` remains
+- Added `@overture-stack/arranger-types` as an explicit dependency in `modules/components/package.json` (`file:../types`) — without this, Turbo's graph treated `components` as independent of `types`, meaning a breaking change to `types` could pass CI without `components` being rebuilt or tested
+- Corrected `modules/graphql-router/package.json` to use the shallower `file:../types` (was `file:../../modules/types` — unnecessarily traversing up to root and back down); `modules/types` already used the shallower `../sqon` convention; `apps/` and `integration-tests/` paths are already as shallow as their locations allow
 - Completed items removed from roadmap (now in sessions only); roadmap stays forward-looking
 
 **Decisions:**

.dev/tech-debt.md

@@ -187,6 +187,14 @@ The preferred pattern is **(B)**. Mixing the two makes it harder to find tests,
 **Fix:** In `spinupActive.js`, after fetching `/introspection/fields`, assert that `Object.keys(data.fields).length` matches the field count from the live ES index (e.g. via a separate `GET /<index>/_mapping` call, or by asserting against a known field that is in the ES mapping but deliberately absent from the test fixture's config files). The simplest approach: add a fixture field directly to the ES test index that is not present in any config file, then assert it appears in the introspection response.
 **Standalone:** yes — additive test, no changes to application code
 
+### Shallow git clone breaks `GIT_PREVIOUS_COMMIT`-based change detection
+**File:** `jenkins-pipeline-library/vars/pipelineOvertureArranger.groovy`
+**Severity:** medium (silently disables change detection — everything would fall back to HEAD^1 or fail)
+**Kind:** ops risk
+**Issue:** The pipeline uses `GIT_PREVIOUS_COMMIT` (set by the Jenkins Git plugin) as the base for all git diff comparisons. If the Jenkins checkout is configured with `--depth 1` (shallow clone), `GIT_PREVIOUS_COMMIT` will not be reachable in the local git history and `git diff ${turboBase} HEAD` will fail. The pipeline comment documents this requirement, but there is no runtime guard — a misconfigured checkout silently degrades or errors.
+**Fix:** Either add a guard (`git cat-file -e ${turboBase} || turboBase = 'HEAD^1'`) to detect and recover from an unreachable commit, or document the shallow-clone restriction in DEVELOPMENT.md alongside the Jenkins setup notes.
+**Standalone:** yes — purely a pipeline change; no application code involved
+
 ### `arranger-iobio` deploy references old `arranger-server` image name
 **File:** infra repo — deploy config for `arranger-iobio` on `overture-dev`
 **Severity:** medium (deploy will reference a stale image name after the Docker rename lands)

docker/Dockerfile.jenkins

@@ -23,6 +23,7 @@ RUN npm ci \
 	--ignore-scripts \
 	--include-workspace-root=false \
 	--workspace apps/search-server \
+	--workspace apps/mcp-server \
 	--workspace modules/graphql-router \
 	--workspace modules/types \
 	--workspace modules/sqon
@@ -32,7 +33,7 @@ CMD ["/bin/sh"]
 #######################################################
 # Arranger Server
 #######################################################
-FROM node:24-alpine AS server
+FROM node:24-alpine AS search-server
 
 ARG APP_FOLDER
 ARG APP_USER

docker/Dockerfile.local

@@ -24,7 +24,7 @@ RUN npm ci --include-workspace-root=false && \
 #######################################################
 # Arranger Server
 #######################################################
-FROM node:24-alpine AS server
+FROM node:24-alpine AS search-server
 
 ARG APP_FOLDER
 ARG APP_USER

integration-tests/server/package.json

@@ -1,5 +1,5 @@
 {
-	"name": "integration-tests-server",
+	"name": "integration-tests-search-server",
 	"dependencies": {
 		"@elastic/elasticsearch": "^7.17.14",
 		"@overture-stack/arranger-graphql-router": "file:../../modules/graphql-router",

modules/components/package.json

@@ -29,6 +29,7 @@
 		"watch": "npm run clear:dist && npm run build -- --watch"
 	},
 	"dependencies": {
+		"@overture-stack/arranger-types": "file:../types",
 		"@emotion/react": "^11.0.0",
 		"@emotion/styled": "^11.0.0",
 		"@overture-stack/sqon-builder": "^1.1.0",

modules/graphql-router/package.json

@@ -37,7 +37,7 @@
 		"@graphql-tools/schema": "^9.0.17",
 		"@graphql-tools/utils": "^10.2.2",
 		"@opensearch-project/opensearch": "^3.6.0",
-		"@overture-stack/arranger-types": "file:../../modules/types",
+		"@overture-stack/arranger-types": "file:../types",
 		"@overture-stack/sqon-builder": "^1.1.0",
 		"apollo-server": "^3.10.3",
 		"apollo-server-core": "^3.10.3",