Repository navigation
Conversation
On Windows, Path.read_text() without encoding uses the ANSI code page (e.g. cp1252), so UTF-8 guides with curly quotes crash the agent setup check. Pin encoding="utf-8" on all three reads and add a regression that simulates a cp1252 default. Fixes huggingface#14837
Author
|
Closing this to keep my open PRs manageable. Happy to reopen and rebase if maintainers want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14837
What was broken
python utils/check_ai.pycrashes on Windows when the default locale encoding is not UTF-8 (typical for a redirected/non-console stdout path — ANSI code page like cp1252). The threePath.read_text()calls inutils/check_ai.pyinherited that locale, so any guide with curly quotes / other non-cp1252 bytes blew up withUnicodeDecodeError.Fix
Pass
encoding="utf-8"on all three reads. Repo Markdown is UTF-8; the check should not depend on the machine locale.How I tested
PYTHONPATH=src:utils python -m pytest tests/others/test_check_ai.py -q # 1 passedThe regression builds a tiny
.ai/tree with U+201C curly quotes and monkeypatchesPath.read_textso a missing encoding falls back to cp1252 — same failure mode as the issue. With the pin,main()returns 0.