Skip to content

_inputstream.EncodingParser fails to parse short bogus comments (prescan) #427

Open

Description

@openandclose

I think abrupt-closing-of-empty-comment ('<!-->' and '<!--->')
should be treated as normal comments in prescan as well.

for '<!-->', the spec states rather explicitly.

The two 0x2D bytes can be the same as those in the '<!--' sequence.'

prescan:
https://html.spec.whatwg.org/multipage/parsing.html#prescan-a-byte-stream-to-determine-its-encoding
abrupt-closing-of-empty-comment:
https://html.spec.whatwg.org/multipage/parsing.html#parse-error-abrupt-closing-of-empty-comment

C.f.
jsdom/html-encoding-sniffer has the same bug.
jsdom/html-encoding-sniffer#4
Validator treats them as comments.

Activity

  1. domenic commented on Jan 5, 2020

    @domenic

    Confirmed the spec says to treat them as comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions